From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7948 Path: news.gmane.org!not-for-mail From: Felix Janda Newsgroups: gmane.linux.lib.musl.general,gmane.comp.security.firewalls.netfilter.devel Subject: [PATCH iptables RFC 4/4] libxt_TCPOPTSTRIP: Use local copy of TCPOPTS constants Date: Tue, 16 Jun 2015 21:25:04 +0200 Message-ID: <20150616192504.GF3247@euler> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1434482746 4208 80.91.229.3 (16 Jun 2015 19:25:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Jun 2015 19:25:46 +0000 (UTC) Cc: musl@lists.openwall.com To: netfilter-devel@vger.kernel.org Original-X-From: musl-return-7961-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jun 16 21:25:46 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Z4wUS-00014y-LI for gllmg-musl@m.gmane.org; Tue, 16 Jun 2015 21:25:44 +0200 Original-Received: (qmail 27666 invoked by uid 550); 16 Jun 2015 19:25:42 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 26603 invoked from network); 16 Jun 2015 19:25:37 -0000 Mail-Followup-To: netfilter-devel@vger.kernel.org, musl@lists.openwall.com Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Xref: news.gmane.org gmane.linux.lib.musl.general:7948 gmane.comp.security.firewalls.netfilter.devel:58048 Archived-At: musl does not provide these constants in Signed-off-by: Felix Janda --- It is not clear to me whether these constants belong to iptables or musl's netinet/tcp.h. So this message is CC'd to the musl list. In the code indexed by debian code search I have only found iptables and traceroute using them without having a local copy of tcp.h. Note that this patch is incomplete: utils/nfsynproxy.c uses them as well --- extensions/libxt_TCPOPTSTRIP.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/extensions/libxt_TCPOPTSTRIP.c b/extensions/libxt_TCPOPTSTRIP.c index 6897857..1617081 100644 --- a/extensions/libxt_TCPOPTSTRIP.c +++ b/extensions/libxt_TCPOPTSTRIP.c @@ -7,11 +7,14 @@ #include #include #include -#include #include -#ifndef TCPOPT_MD5SIG -# define TCPOPT_MD5SIG 19 -#endif + +#define TCPOPT_MAXSEG 2 +#define TCPOPT_WINDOW 3 +#define TCPOPT_SACK_PERMITTED 4 +#define TCPOPT_SACK 5 +#define TCPOPT_TIMESTAMP 8 +#define TCPOPT_MD5SIG 19 enum { O_STRIP_OPTION = 0, -- 2.3.6