From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/5] dynlink.c: compute modulus via magic multiplication
Date: Wed, 24 Jun 2015 00:19:50 -0400 [thread overview]
Message-ID: <20150624041950.GM1173@brightrain.aerifal.cx> (raw)
In-Reply-To: <alpine.LNX.2.11.1506240717180.9758@monopod.intra.ispras.ru>
On Wed, Jun 24, 2015 at 07:18:28AM +0300, Alexander Monakov wrote:
> On Wed, 24 Jun 2015, Alexander Monakov wrote:
> > diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c
> > index fa91b39..99dadd4 100644
> > --- a/src/ldso/dynlink.c
> > +++ b/src/ldso/dynlink.c
> > @@ -41,6 +41,11 @@ struct td_index {
> > struct td_index *next;
> > };
> >
> > +struct udiv {
> > + uint32_t mul;
> > + int s1, s2, inc;
> > +};
>
> Can use 'char' rather than 'int' here.
Yes, that seems like a nice size improvement, and it might also allow
the compiler to do additional optimizations based on knowledge of the
range.
Rich
next prev parent reply other threads:[~2015-06-24 4:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 23:24 [PATCH 0/5] gnu-hash speedups Alexander Monakov
2015-06-23 23:24 ` [PATCH 1/5] dynlink.c: use bloom filter in gnu hash lookup Alexander Monakov
2015-06-24 5:39 ` Rich Felker
2015-06-24 6:29 ` Alexander Monakov
2015-06-24 6:32 ` Alexander Monakov
2015-06-24 6:50 ` Rich Felker
2015-06-23 23:24 ` [PATCH 2/5] dynlink.c: compute modulus via magic multiplication Alexander Monakov
2015-06-24 4:18 ` Alexander Monakov
2015-06-24 4:19 ` Rich Felker [this message]
2015-06-24 4:24 ` Rich Felker
2015-06-24 4:32 ` Alexander Monakov
2015-06-24 5:13 ` Rich Felker
2015-06-24 6:08 ` Alexander Monakov
2015-06-24 6:39 ` Rich Felker
2015-06-23 23:24 ` [PATCH 3/5] dynlink.c: slim down gnu_lookup Alexander Monakov
2015-06-23 23:24 ` [PATCH 4/5] dynlink.c: pass gnu-hash table pointer to gnu_lookup Alexander Monakov
2015-06-23 23:24 ` [PATCH 5/5] dynlink.c: use a faster expression in gnu_hash Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 0/6] gnu-hash speedups Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 1/6] dynlink.c: use a faster expression in gnu_hash Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 2/6] dynlink.c: use bloom filter in gnu hash lookup Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 3/6] dynlink.c: slim down gnu_lookup Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 4/6] dynlink.c: pass gnu-hash table pointer to gnu_lookup Alexander Monakov
2015-06-28 0:05 ` Alexander Monakov
2015-06-28 8:59 ` Alexander Monakov
2015-06-27 23:48 ` [PATCH v2 5/6] dynlink.c: compute modulus via magic multiplication Alexander Monakov
2015-06-30 17:51 ` Rich Felker
2015-06-27 23:48 ` [PATCH v2 6/6] dynlink.c: store bloom filter size in struct dso Alexander Monakov
2015-06-28 2:45 ` [PATCH v2 0/6] gnu-hash speedups Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624041950.GM1173@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).