mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH v9] Build process uses script to add CFI directives to x86 asm
Date: Wed, 8 Jul 2015 10:16:37 -0400	[thread overview]
Message-ID: <20150708141637.GO1173@brightrain.aerifal.cx> (raw)
In-Reply-To: <CACsECNesuViKe0eAarU7yk6xdz6W6N=1txtXC8=ytyZRMfAR8g@mail.gmail.com>

On Wed, Jun 24, 2015 at 07:33:54AM +0200, Alex wrote:
> On Tue, Jun 23, 2015 at 11:52 PM, Rich Felker <dalias@libc.org> wrote:
> 
> > On Tue, Jun 23, 2015 at 09:18:08PM +0200, Alex Dowad wrote:
> > > ../configure now checks CFLAGS as well as CFLAGS_AUTO to see if
> > generation of debug
> > > info was requested.
> > >
> > > The idea of removing duplication from the Makefile using a new AS_CMD
> > variable has
> > > come up several times, but this will not work because the arguments need
> > to be
> > > inserted in different places. I have tried using a Makefile 'define'
> > instead.
> > > Please see whether you like the way this code reads or not.
> > >
> > > Subarch asm files are treated the same as other asm files. Please note
> > that
> > > since I don't own the hardware, I can't test whether these Makefile
> > rules work or not.
> >
> > I should have mentioned -- the CFLAGS_ALL_STATIC/_SHARED variants are
> > meaningless to asm, so it would work fine to just use $(CFLAGS_ALL);
> > then there's no need for fancy tricks, and a simple make variable
> > should work, I think.
> 
> A simple make variable works for the non-subarch rules. But what to do for
> the subarch rules, which use $(dir $<)$(shell cat $<)?

A nasty complication: some of the .sub files sub-in a .c file instead
of a .s file. This is horribly nasty and probably not something I
should have done. x86 is not affected, but it probably means we should
not try applying the CFI stuff in the makefile to .sub rules yet.

Rich


  parent reply	other threads:[~2015-07-08 14:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 19:18 Alex Dowad
2015-06-23 21:52 ` Rich Felker
2015-06-24  5:33   ` Alex
2015-06-28  2:58     ` Rich Felker
2015-07-08 14:16     ` Rich Felker [this message]
2015-07-08 14:25       ` Alex
2015-07-09  5:00         ` Rich Felker
2015-07-07  3:39 ` Rich Felker
2015-07-07  5:45   ` Alex
2015-07-07 13:21     ` Rich Felker
2015-07-07 16:40       ` Alex
2015-07-07 18:15         ` Rich Felker
2015-07-07 18:27           ` Alex
     [not found]             ` <20150708023638.GJ1173@brightrain.aerifal.cx>
2015-07-08  7:13               ` Alex
2015-07-08  7:54                 ` Alex
2015-07-08 14:11                   ` Rich Felker
2015-07-08 14:24                     ` Alex
  -- strict thread matches above, loose matches on Subject: below --
2015-06-15  6:45 Alex Dowad
2015-06-20 21:11 ` Rich Felker
2015-06-21  5:00   ` Alex
2015-06-21  5:05     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150708141637.GO1173@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).