From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8139 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v9] Build process uses script to add CFI directives to x86 asm Date: Thu, 9 Jul 2015 01:00:11 -0400 Message-ID: <20150709050011.GQ1173@brightrain.aerifal.cx> References: <1435087088-9860-1-git-send-email-alexinbeijing@gmail.com> <20150623215212.GK1173@brightrain.aerifal.cx> <20150708141637.GO1173@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1436418032 14998 80.91.229.3 (9 Jul 2015 05:00:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jul 2015 05:00:32 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8152-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 09 07:00:32 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZD3wj-0007F9-68 for gllmg-musl@m.gmane.org; Thu, 09 Jul 2015 07:00:29 +0200 Original-Received: (qmail 15636 invoked by uid 550); 9 Jul 2015 05:00:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 15612 invoked from network); 9 Jul 2015 05:00:25 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:8139 Archived-At: On Wed, Jul 08, 2015 at 04:25:47PM +0200, Alex wrote: > On Wed, Jul 8, 2015 at 4:16 PM, Rich Felker wrote: > > A nasty complication: some of the .sub files sub-in a .c file instead > > of a .s file. This is horribly nasty and probably not something I > > should have done. x86 is not affected, but it probably means we should > > not try applying the CFI stuff in the makefile to .sub rules yet. > > You are absolutely right about this. I will remove those Makefile rules. -- AD In that case I think we can just use a variable for the command. Hopefully by the time we need to support archs with sub file controlled asm, changes to the build system will have eliminated the whole sub file mess and we'll just multiple implicit rules in proper precedence order to get the right files used. This should considerably improve 'make' start latency too, which suffers a lot from the function for sub file dependencies. Rich