From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8145 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] syncfs: return a status integer Date: Thu, 9 Jul 2015 12:34:50 -0400 Message-ID: <20150709163450.GS1173@brightrain.aerifal.cx> References: <1436443136-12394-1-git-send-email-ncopa@alpinelinux.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1436459707 5109 80.91.229.3 (9 Jul 2015 16:35:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jul 2015 16:35:07 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8158-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 09 18:35:07 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZDEmv-0001Kk-0A for gllmg-musl@m.gmane.org; Thu, 09 Jul 2015 18:35:05 +0200 Original-Received: (qmail 15453 invoked by uid 550); 9 Jul 2015 16:35:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 15432 invoked from network); 9 Jul 2015 16:35:02 -0000 Content-Disposition: inline In-Reply-To: <1436443136-12394-1-git-send-email-ncopa@alpinelinux.org> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:8145 Archived-At: On Thu, Jul 09, 2015 at 01:58:56PM +0200, Natanael Copa wrote: > syncfs(2) may fail with EBADF if fd is not a vaild file descriptor. We > need return error to follow glibc ABI. Minor nit in commit message: this is just the documented _API_ for the (nonstandard) function, not ABI-specific (although of course API mismatch usually also introduces ABI mismatch, including in this case). Rich