From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix termios custom speed field names
Date: Sun, 13 Sep 2015 12:58:26 -0400 [thread overview]
Message-ID: <20150913165826.GD17773@brightrain.aerifal.cx> (raw)
In-Reply-To: <1442162858-4004-1-git-send-email-nbd@openwrt.org>
On Sun, Sep 13, 2015 at 06:47:38PM +0200, Felix Fietkau wrote:
> Using c_ispeed/c_ospeed is necessary for setting custom baud rates not
> covered by the existing defines (via BOTHER).
> Rename those fields to match glibc/uClibc.
Did you check that they actually work and match the kernel ABI? I seem
to recallthat on most archs, the kernel ignores them. Since c_* is in
the reserved namespace for this header, exposing these names is ok by
the standard, but I wonder if having non-working fields visible breaks
anything...?
Rich
prev parent reply other threads:[~2015-09-13 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:47 Felix Fietkau
2015-09-13 16:58 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150913165826.GD17773@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).