From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8516 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] libintl.h: Add format argument attributes to gettext function prototypes Date: Tue, 15 Sep 2015 16:35:54 -0400 Message-ID: <20150915203554.GR17773@brightrain.aerifal.cx> References: <1442125744-27934-1-git-send-email-raj.khem@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1442349384 6356 80.91.229.3 (15 Sep 2015 20:36:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 20:36:24 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8528-gllmg-musl=m.gmane.org@lists.openwall.com Tue Sep 15 22:36:15 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZbwxX-0004zE-8r for gllmg-musl@m.gmane.org; Tue, 15 Sep 2015 22:36:11 +0200 Original-Received: (qmail 3277 invoked by uid 550); 15 Sep 2015 20:36:08 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 3253 invoked from network); 15 Sep 2015 20:36:08 -0000 Content-Disposition: inline In-Reply-To: <1442125744-27934-1-git-send-email-raj.khem@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:8516 Archived-At: On Sun, Sep 13, 2015 at 06:29:04AM +0000, Khem Raj wrote: > compiling glib-2.0 clang errors out with > > error: format string is not a string literal > > when these functions are used, it can be enforced that the format > arguments to these gettext* functions be string literals, so that the compiler knows that it > always will be string literals > > Signed-off-by: Khem Raj > --- > include/libintl.h | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) Thanks! Committed with changes to log message only. Rich