From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: localeconv and char values
Date: Mon, 21 Sep 2015 10:54:25 -0400 [thread overview]
Message-ID: <20150921145425.GQ17773@brightrain.aerifal.cx> (raw)
In-Reply-To: <89422A70-4BF6-4733-9400-0932A85857F9@gmail.com>
On Mon, Sep 21, 2015 at 12:21:34PM +0200, Julien Ramseier wrote:
> Hello,
>
> Currently, all the char fields of the lconv struct returned by
> localeconv are set to -1.
>
> According to
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/localeconv.html
> <http://pubs.opengroup.org/onlinepubs/9699919799/functions/localeconv.html>,
> negative values are not valid and CHAR_MAX should be used to
> indicate non-available values.
As far as I can tell, you are right. I don't know how I
overlooked/misread this, except perhaps that using CHAR_MAX is rather
ugly/inappropriate because it assumes CHAR_MAX is not an interesting
character that could be used for these purposes. Thankfully that's
true for ASCII and ASCII supersets (in our case, UTF-8), so it's not a
practical problem.
> If I’m not missing anything, here’s the corresponding patch:
I'll look it over again before committing, but I don't see anything
immediately wrong with it. Thanks!
Rich
next prev parent reply other threads:[~2015-09-21 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 10:21 Julien Ramseier
2015-09-21 14:54 ` Rich Felker [this message]
2015-09-21 20:23 ` Rich Felker
2015-09-22 7:37 ` Julien Ramseier
2015-09-24 6:45 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921145425.GQ17773@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).