getaddrinfo and null args

getaddrinfo and null args

[Julien Ramseier]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hello,

According to http://pubs.opengroup.org/onlinepubs/9699919799/functions/freeaddrinfo.html:
"The nodename and servname arguments are either null pointers or pointers
 to null-terminated strings. One or both of these two arguments shall be supplied 
by the application as a non-null pointer. "
"[EAI_NONAME]
Neither nodename nor servname were supplied. At least one of these shall be supplied."

getaddrinfo() currently accepts both nodename and servname being null.
Following patch fixes the problem:


[-- Attachment #2: fix-getaddrinfo-both-null-args.diff --]
[-- Type: application/octet-stream, Size: 411 bytes --]

diff --git a/src/network/getaddrinfo.c b/src/network/getaddrinfo.c
index c88d558..d69ec98 100644
--- a/src/network/getaddrinfo.c
+++ b/src/network/getaddrinfo.c
@@ -20,6 +20,9 @@ int getaddrinfo(const char *restrict host, const char *restrict serv, const stru
 		} sa;
 	} *out;
 
+	if (host == NULL && serv == NULL)
+		return EAI_NONAME;
+
 	if (hint) {
 		family = hint->ai_family;
 		flags = hint->ai_flags;

[-- Attachment #3: Type: text/plain, Size: 15 bytes --]



—
Julien

Re: getaddrinfo and null args

[Rich Felker]

On Tue, Sep 22, 2015 at 01:40:13PM +0200, Julien Ramseier wrote:
> Hello,
> 
> According to http://pubs.opengroup.org/onlinepubs/9699919799/functions/freeaddrinfo.html:
> "The nodename and servname arguments are either null pointers or pointers
>  to null-terminated strings. One or both of these two arguments shall be supplied 
> by the application as a non-null pointer. "
> "[EAI_NONAME]
> Neither nodename nor servname were supplied. At least one of these shall be supplied."
> 
> getaddrinfo() currently accepts both nodename and servname being null.
> Following patch fixes the problem:

Thanks! Committed with minor changes for preferred style in musl.

Rich