mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH] mips/fenv: fix fesetround by setting rounding mode
@ 2015-09-28 10:38 Anand Takale
  2015-09-28 11:09 ` Szabolcs Nagy
  2015-10-01  5:13 ` Rich Felker
  0 siblings, 2 replies; 3+ messages in thread
From: Anand Takale @ 2015-09-28 10:38 UTC (permalink / raw)
  To: musl

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

mips fesetround does not write back the rounding mode to FCSR


diff --git a/src/fenv/mips/fenv.s b/src/fenv/mips/fenv.s
index 9b45ffc..f60b0e7 100644
--- a/src/fenv/mips/fenv.s
+++ b/src/fenv/mips/fenv.s
@@ -43,6 +43,7 @@ __fesetround:
        li      $6, -4
        and     $5, $5, $6
        or      $5, $5, $4
+       ctc1    $5, $31
        jr      $ra
        li      $2, 0

[-- Attachment #2: Type: text/html, Size: 2873 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mips/fenv: fix fesetround by setting rounding mode
  2015-09-28 10:38 [PATCH] mips/fenv: fix fesetround by setting rounding mode Anand Takale
@ 2015-09-28 11:09 ` Szabolcs Nagy
  2015-10-01  5:13 ` Rich Felker
  1 sibling, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2015-09-28 11:09 UTC (permalink / raw)
  To: musl

* Anand Takale <Anand.Takale@imgtec.com> [2015-09-28 10:38:36 +0000]:
> mips fesetround does not write back the rounding mode to FCSR
> 

looks ok
thanks

> 
> diff --git a/src/fenv/mips/fenv.s b/src/fenv/mips/fenv.s
> index 9b45ffc..f60b0e7 100644
> --- a/src/fenv/mips/fenv.s
> +++ b/src/fenv/mips/fenv.s
> @@ -43,6 +43,7 @@ __fesetround:
>         li      $6, -4
>         and     $5, $5, $6
>         or      $5, $5, $4
> +       ctc1    $5, $31
>         jr      $ra
>         li      $2, 0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mips/fenv: fix fesetround by setting rounding mode
  2015-09-28 10:38 [PATCH] mips/fenv: fix fesetround by setting rounding mode Anand Takale
  2015-09-28 11:09 ` Szabolcs Nagy
@ 2015-10-01  5:13 ` Rich Felker
  1 sibling, 0 replies; 3+ messages in thread
From: Rich Felker @ 2015-10-01  5:13 UTC (permalink / raw)
  To: musl

On Mon, Sep 28, 2015 at 10:38:36AM +0000, Anand Takale wrote:
> mips fesetround does not write back the rounding mode to FCSR
> 
> 
> diff --git a/src/fenv/mips/fenv.s b/src/fenv/mips/fenv.s
> index 9b45ffc..f60b0e7 100644
> --- a/src/fenv/mips/fenv.s
> +++ b/src/fenv/mips/fenv.s
> @@ -43,6 +43,7 @@ __fesetround:
>         li      $6, -4
>         and     $5, $5, $6
>         or      $5, $5, $4
> +       ctc1    $5, $31
>         jr      $ra
>         li      $2, 0

Thanks! Applied.

Rich


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-01  5:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-28 10:38 [PATCH] mips/fenv: fix fesetround by setting rounding mode Anand Takale
2015-09-28 11:09 ` Szabolcs Nagy
2015-10-01  5:13 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).