From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8590
Path: news.gmane.org!not-for-mail
From: Rich Felker <dalias@libc.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH] mips/fenv: fix fesetround by setting rounding mode
Date: Thu, 1 Oct 2015 01:13:06 -0400
Message-ID: <20151001051306.GH8645@brightrain.aerifal.cx>
References: <43DB94F35C9F9E47834E992E8B3C7AF16E67C374@PUMAIL01.pu.imgtec.org>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1443676409 28455 80.91.229.3 (1 Oct 2015 05:13:29 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 1 Oct 2015 05:13:29 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-8602-gllmg-musl=m.gmane.org@lists.openwall.com Thu Oct 01 07:13:24 2015
Return-path: <musl-return-8602-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-8602-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1ZhWBH-0004YR-HW
	for gllmg-musl@m.gmane.org; Thu, 01 Oct 2015 07:13:23 +0200
Original-Received: (qmail 27704 invoked by uid 550); 1 Oct 2015 05:13:20 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 27683 invoked from network); 1 Oct 2015 05:13:19 -0000
Content-Disposition: inline
In-Reply-To: <43DB94F35C9F9E47834E992E8B3C7AF16E67C374@PUMAIL01.pu.imgtec.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Original-Sender: Rich Felker <dalias@aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:8590
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/8590>

On Mon, Sep 28, 2015 at 10:38:36AM +0000, Anand Takale wrote:
> mips fesetround does not write back the rounding mode to FCSR
> 
> 
> diff --git a/src/fenv/mips/fenv.s b/src/fenv/mips/fenv.s
> index 9b45ffc..f60b0e7 100644
> --- a/src/fenv/mips/fenv.s
> +++ b/src/fenv/mips/fenv.s
> @@ -43,6 +43,7 @@ __fesetround:
>         li      $6, -4
>         and     $5, $5, $6
>         or      $5, $5, $4
> +       ctc1    $5, $31
>         jr      $ra
>         li      $2, 0

Thanks! Applied.

Rich