From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/3] Pull a couple common AWK functions for CFI scripts into separate file
Date: Fri, 2 Oct 2015 06:18:23 -0400 [thread overview]
Message-ID: <20151002101823.GR8645@brightrain.aerifal.cx> (raw)
In-Reply-To: <1443780123-6493-1-git-send-email-alexinbeijing@gmail.com>
On Fri, Oct 02, 2015 at 12:02:01PM +0200, Alex Dowad wrote:
> There is a lot which could be common between i386 and x86_64, but none of it
> will be useful for any other arch. These should be useful for all archs,
> however.
> ---
> Makefile | 2 +-
> tools/add-cfi.i386.awk | 27 ---------------------------
> tools/common.awk | 26 ++++++++++++++++++++++++++
> 3 files changed, 27 insertions(+), 28 deletions(-)
> create mode 100644 tools/common.awk
>
> diff --git a/Makefile b/Makefile
> index 5a6a43b..761482d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -122,7 +122,7 @@ $(foreach s,$(wildcard src/*/$(ARCH)*/*.s),$(eval $(call mkasmdep,$(s))))
> # Choose invocation of assembler to be used
> # $(1) is input file, $(2) is output file, $(3) is assembler flags
> ifeq ($(ADD_CFI),yes)
> - AS_CMD = LC_ALL=C awk -f tools/add-cfi.$(ARCH).awk $< | $(CC) -x assembler -c -o $@ -
> + AS_CMD = LC_ALL=C awk -f tools/common.awk -f tools/add-cfi.$(ARCH).awk $< | $(CC) -x assembler -c -o $@ -
Is the name common.awk appropriate? (common to what?) Maybe cfi-common
or something that indicates it's for the cfi scripts.
Great to see further work on this!
Rich
prev parent reply other threads:[~2015-10-02 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 10:02 Alex Dowad
2015-10-02 10:02 ` [PATCH 2/3] When generating CFI for i386 asm, don't mistake an FDIV instruction for DIV Alex Dowad
2015-10-02 10:02 ` [PATCH 3/3] Add script to add CFI directives to asm files in debug builds of x86_64 Alex Dowad
2015-10-02 10:19 ` Rich Felker
2015-10-02 10:58 ` Alex
2015-10-02 11:01 ` Alex
2015-10-02 10:18 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002101823.GR8645@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).