From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8598 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/3] Pull a couple common AWK functions for CFI scripts into separate file Date: Fri, 2 Oct 2015 06:18:23 -0400 Message-ID: <20151002101823.GR8645@brightrain.aerifal.cx> References: <1443780123-6493-1-git-send-email-alexinbeijing@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1443781126 22912 80.91.229.3 (2 Oct 2015 10:18:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Oct 2015 10:18:46 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8610-gllmg-musl=m.gmane.org@lists.openwall.com Fri Oct 02 12:18:39 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZhxQE-0004D2-OP for gllmg-musl@m.gmane.org; Fri, 02 Oct 2015 12:18:38 +0200 Original-Received: (qmail 9862 invoked by uid 550); 2 Oct 2015 10:18:37 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 9844 invoked from network); 2 Oct 2015 10:18:36 -0000 Content-Disposition: inline In-Reply-To: <1443780123-6493-1-git-send-email-alexinbeijing@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:8598 Archived-At: On Fri, Oct 02, 2015 at 12:02:01PM +0200, Alex Dowad wrote: > There is a lot which could be common between i386 and x86_64, but none of it > will be useful for any other arch. These should be useful for all archs, > however. > --- > Makefile | 2 +- > tools/add-cfi.i386.awk | 27 --------------------------- > tools/common.awk | 26 ++++++++++++++++++++++++++ > 3 files changed, 27 insertions(+), 28 deletions(-) > create mode 100644 tools/common.awk > > diff --git a/Makefile b/Makefile > index 5a6a43b..761482d 100644 > --- a/Makefile > +++ b/Makefile > @@ -122,7 +122,7 @@ $(foreach s,$(wildcard src/*/$(ARCH)*/*.s),$(eval $(call mkasmdep,$(s)))) > # Choose invocation of assembler to be used > # $(1) is input file, $(2) is output file, $(3) is assembler flags > ifeq ($(ADD_CFI),yes) > - AS_CMD = LC_ALL=C awk -f tools/add-cfi.$(ARCH).awk $< | $(CC) -x assembler -c -o $@ - > + AS_CMD = LC_ALL=C awk -f tools/common.awk -f tools/add-cfi.$(ARCH).awk $< | $(CC) -x assembler -c -o $@ - Is the name common.awk appropriate? (common to what?) Maybe cfi-common or something that indicates it's for the cfi scripts. Great to see further work on this! Rich