From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 3/3] Add script to add CFI directives to asm files in debug builds of x86_64
Date: Fri, 2 Oct 2015 06:19:21 -0400 [thread overview]
Message-ID: <20151002101921.GS8645@brightrain.aerifal.cx> (raw)
In-Reply-To: <1443780123-6493-3-git-send-email-alexinbeijing@gmail.com>
On Fri, Oct 02, 2015 at 12:02:03PM +0200, Alex Dowad wrote:
> +# this does NOT exhaustively check for all possible instructions which could
> +# overwrite a register value inherited from the caller (just the common ones)
> +/mov.*,%r(ax|bx|cx|dx|si|di|bp|8|9|10|11|12|13|14|15)/ { trashed(get_reg2()) }
> +/(add|addl|sub|subl|and|or|xor|lea|sal|sar|shl|shr) %r(ax|bx|cx|dx|si|di|bp|8|9|10|11|12|13|14|15),/ {
> + trashed(get_reg1())
> +}
This looks wrong but maybe it's already wrong in existing code. Why
are you marking the first operand as trashed rather than the second?
Rich
next prev parent reply other threads:[~2015-10-02 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 10:02 [PATCH 1/3] Pull a couple common AWK functions for CFI scripts into separate file Alex Dowad
2015-10-02 10:02 ` [PATCH 2/3] When generating CFI for i386 asm, don't mistake an FDIV instruction for DIV Alex Dowad
2015-10-02 10:02 ` [PATCH 3/3] Add script to add CFI directives to asm files in debug builds of x86_64 Alex Dowad
2015-10-02 10:19 ` Rich Felker [this message]
2015-10-02 10:58 ` Alex
2015-10-02 11:01 ` Alex
2015-10-02 10:18 ` [PATCH 1/3] Pull a couple common AWK functions for CFI scripts into separate file Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002101921.GS8645@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).