mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCHv3 1/3] fix matching errors for overwritten registers in x86 CFI generation script
Date: Wed, 14 Oct 2015 15:14:08 -0400	[thread overview]
Message-ID: <20151014191408.GU8645@brightrain.aerifal.cx> (raw)
In-Reply-To: <CACsECNd+C1jvfke4FDVY8wJ6w8hf_m_t8efsS=pzGOkqx4r1XA@mail.gmail.com>

On Wed, Oct 14, 2015 at 12:21:05PM +0200, Alex wrote:
> On Wed, Oct 14, 2015 at 12:42 AM, Rich Felker <dalias@libc.org> wrote:
> 
> > On Tue, Oct 13, 2015 at 01:28:50PM +0200, Alex Dowad wrote:
> > > Here is the latest iteration. I have merged 2 previously separate
> > commits, and
> > > fixed up the matching of registers (for the purpose of identifying
> > overwritten
> > > registers).
> > >
> > > As usual, thanks for the feedback. AD
> >
> > Thanks! I'm committing them all now. I'm sorry for not catching this
> > before -- I realized that the index register thing was also an
> > existing bug in mov handling, not just a new bug added in the operand
> > order patch, so I split it out into a separate commit. I did basic
> > regression testing on i386 (making sure gdb backtrace from syscalls
> > still works) and tested that the x86_64 also seems to work (it does).
> 
> Thanks!
> 
> This has been an interesting exercise so far. Is there any other arch which
> you think it would be worthwhile to develop a CFI generation script for? It
> should be something which has enough users to avoid problems with bitrot.

CFI is probably a lot less interesting on archs where you have a
plenty registers not to need to manipulate stack frames in asm
functions, since in that case the debugger mostly works fine without
CFI. I don't know right off which of the other archs have significant
amounts of asm that adjusts the stack pointer, but you could go
through and check them. Having ABI info for them all would be helpful;
I'm pasting my draft ABI reference (which might have errors) below.

Rich




aarch64
...
x30 lr
x31 zr or pc

arm
r0-r3 args/ret
r4-r11 saved
r12 temp (ip scratch)
r13 sp
r14 lr
r15 pc

microblaze
r0 zero
r1 sp
r2 ro sda
r3-r4 ret
r5-r10 args
r11-12 temp
r13 rw sda
r14 syscall ret addr
r15 function ret addr
r16 break ret addr
r17 exception ret addr
r18 assembler temp
r19-r20 saved
r21 thread pointer
r21-r31 saved

mips (http://www.inf.ed.ac.uk/teaching/courses/car/Notes/slide03.pdf)
$0 zero
$1 at (assembler temp)
$2-$3 ret (aka v0-v1)
$4-$7 args (aka a0-a3)
$8-$15 temp (aka t0-t7)
$16-$23 saved (aka s0-s7
$24 temp (aka t8)
$25 function call addr (aka t9)
$26-$27 kernel use
$28 gp, call-clobbered
$29 sp
$30 fp
$31 ra

or1k (openrisc-arch-1.1-rev0.pdf p.335)
r0 zero
r1 sp
r2 fp
r3-r8 args
r9 lr
r11,r12 retval (lo,hi)
r10 thread pointer
r14-r30(even) saved
r13-r31(odd) temp

powerpc (http://www.csd.uwo.ca/~mburrel/stuff/ppc-asm.html http://devpit.org/wiki/Debugging_PowerPC_ELF_Binaries)
0 temp
1 sp
2 toc (thread pointer)
3 ret, arg0
4-10 args
11-12 temp
13-31 saved
lr (not gpr; use mtlr/mflr)
30 got
11 plt temp
ctr plt temp

superh (http://www.st.com/st-web-ui/static/active/en/resource/technical/document/reference_manual/CD17839242.pdf p.9)
(http://shared-ptr.com/sh_insns.html)
r0-r3 ret
r2 struct ret addr
r4-r7 args
r8-r13 saved
r12 gp (saved)
r14 fp (saved)
r15 sp
pr lr
gbr thread ptr


  reply	other threads:[~2015-10-14 19:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 11:28 Alex Dowad
2015-10-13 11:28 ` [PATCH 2/3] x86 CFI generation script recognizes when %ax, %ah, %al, etc. are overwritten Alex Dowad
2015-10-13 11:28 ` [PATCH 3/3] add CFI generation script for x86_64 Alex Dowad
2015-10-13 22:42 ` [PATCHv3 1/3] fix matching errors for overwritten registers in x86 CFI generation script Rich Felker
2015-10-14 10:21   ` Alex
2015-10-14 19:14     ` Rich Felker [this message]
2015-10-14 19:23       ` Alex
2015-10-14 19:27         ` Rich Felker
2015-10-14 19:44           ` Alex
2015-10-14 19:51             ` Rich Felker
2015-10-14 20:27               ` Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014191408.GU8645@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).