mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/3] i386/memset: argument load code need not be separate
Date: Wed, 14 Oct 2015 19:20:49 -0400	[thread overview]
Message-ID: <20151014232049.GZ8645@brightrain.aerifal.cx> (raw)
In-Reply-To: <1444674635-25421-1-git-send-email-vda.linux@googlemail.com>

On Mon, Oct 12, 2015 at 08:30:32PM +0200, Denys Vlasenko wrote:
> "large memset" and "small memset" code paths were using two separate copies
> of loads from 8(%esp) and 4(%esp). No need to have this duplication.
> [...]

Thanks! I'm in the middle of trying to clear out the pending
issue/patch queue for 1.1.12 right now, so I'm going to hold off on
running the benchmarks and reviewing this series until after the
release. As you recall, tweaking these functions can turn into a time
sink for me. :-) But I do want to acknowledge receiving your patches
and let you know that I plan to look at them soon.

Rich


      parent reply	other threads:[~2015-10-14 23:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 18:30 Denys Vlasenko
2015-10-12 18:30 ` [PATCH 2/3] i386/memset: do not fetch fill char from memory again Denys Vlasenko
2015-11-05  2:54   ` Rich Felker
2015-10-12 18:30 ` [PATCH 3/3] i386/memset: move byte-extending IMUL up, drop one insn Denys Vlasenko
2015-10-14 23:20 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014232049.GZ8645@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).