From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8674 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/3] i386/memset: argument load code need not be separate Date: Wed, 14 Oct 2015 19:20:49 -0400 Message-ID: <20151014232049.GZ8645@brightrain.aerifal.cx> References: <1444674635-25421-1-git-send-email-vda.linux@googlemail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1444864873 19735 80.91.229.3 (14 Oct 2015 23:21:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Oct 2015 23:21:13 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8686-gllmg-musl=m.gmane.org@lists.openwall.com Thu Oct 15 01:21:07 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZmVM3-0005x3-LF for gllmg-musl@m.gmane.org; Thu, 15 Oct 2015 01:21:07 +0200 Original-Received: (qmail 24460 invoked by uid 550); 14 Oct 2015 23:21:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 24442 invoked from network); 14 Oct 2015 23:21:03 -0000 Content-Disposition: inline In-Reply-To: <1444674635-25421-1-git-send-email-vda.linux@googlemail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:8674 Archived-At: On Mon, Oct 12, 2015 at 08:30:32PM +0200, Denys Vlasenko wrote: > "large memset" and "small memset" code paths were using two separate copies > of loads from 8(%esp) and 4(%esp). No need to have this duplication. > [...] Thanks! I'm in the middle of trying to clear out the pending issue/patch queue for 1.1.12 right now, so I'm going to hold off on running the benchmarks and reviewing this series until after the release. As you recall, tweaking these functions can turn into a time sink for me. :-) But I do want to acknowledge receiving your patches and let you know that I plan to look at them soon. Rich