From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH v2 2/2] pthread: implement try/timed join variants
Date: Thu, 15 Oct 2015 23:15:37 -0400 [thread overview]
Message-ID: <20151016031537.GD8645@brightrain.aerifal.cx> (raw)
In-Reply-To: <20151012023020.GM8645@brightrain.aerifal.cx>
On Sun, Oct 11, 2015 at 10:30:20PM -0400, Rich Felker wrote:
> > +int __pthread_timedjoin_np(pthread_t t, void **res, const struct timespec *at)
> > +{
> > + int tmp, cs, r = 0;
> > + __pthread_testcancel();
> > + __pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &cs);
> > + if (cs == PTHREAD_CANCEL_ENABLE) __pthread_setcancelstate(cs, 0);
> > + while ((tmp = t->tid) && r != ETIMEDOUT && r != EINVAL)
> > + r = __timedwait_cp(&t->tid, tmp, CLOCK_REALTIME, at, 0);
> > + __pthread_setcancelstate(cs, 0);
> > + if (r == ETIMEDOUT || r == EINVAL) return r;
> > + return __pthread_tryjoin_np(t, res);
> > +}
> > +
> > +int __pthread_join(pthread_t t, void **res)
> > +{
> > + return __pthread_timedjoin_np(t, res, 0);
> > +}
> > +
> > +weak_alias(__pthread_tryjoin_np, pthread_tryjoin_np);
> > +weak_alias(__pthread_timedjoin_np, pthread_timedjoin_np);
> > weak_alias(__pthread_join, pthread_join);
>
> This all looks okay to me. I'll probably commit the patch as-is, as
> long as nobody thinks the reasoning on the tryjoin issue above is
> wrong.
I went ahead and committed patch 1 since it's an obvious bug fix. The
second patch still looks ok to me but I'm going to hold off until
after release because I don't want to rush addition of a new
nonstandard extension without good review.
Rich
next prev parent reply other threads:[~2015-10-16 3:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 19:55 [PATCH v2 1/2] pthread: add missing memory barrier Bobby Bingham
2015-10-04 19:55 ` [PATCH v2 2/2] pthread: implement try/timed join variants Bobby Bingham
2015-10-12 2:30 ` Rich Felker
2015-10-16 3:15 ` Rich Felker [this message]
2016-05-07 18:48 ` [PATCH v3] " Bobby Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016031537.GD8645@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).