mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Cc: Rich Felker <dalias@libc.org>, Denys Vlasenko <vda.linux@googlemail.com>
Subject: Re: [PATCH] make CFLAGS=foo considered harmful
Date: Fri, 23 Oct 2015 10:51:21 +0200	[thread overview]
Message-ID: <20151023085120.GH10551@port70.net> (raw)
In-Reply-To: <1445582865-4141-1-git-send-email-vda.linux@googlemail.com>

* Denys Vlasenko <vda.linux@googlemail.com> [2015-10-23 08:47:45 +0200]:
> +Note that overriding variables on make command line (IOW, running
> +make CFLAGS="...") is not tested to work properly, and may result
> +in a severely suboptimal build. Place your overrides into environment:
> +
> +  export CFLAGS="..."; make
> +
> +or
> +
> +  CFLAGS="..." make
> +

i think that does not work, env vars affect make vars if

 VAR ?=
 VAR +=

or no VAR assignment is used in the makefile.

musl happens to use CFLAGS= in config.mak

>  EOF
>  exit 0
>  }
> -- 
> 1.8.1.4


  reply	other threads:[~2015-10-23  8:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23  6:47 Denys Vlasenko
2015-10-23  8:51 ` Szabolcs Nagy [this message]
2015-10-23 11:15 ` Luca Barbato
2015-10-23 12:46   ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151023085120.GH10551@port70.net \
    --to=nsz@port70.net \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).