From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8735
Path: news.gmane.org!not-for-mail
From: Szabolcs Nagy <nsz@port70.net>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH] make CFLAGS=foo considered harmful
Date: Fri, 23 Oct 2015 10:51:21 +0200
Message-ID: <20151023085120.GH10551@port70.net>
References: <1445582865-4141-1-git-send-email-vda.linux@googlemail.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1445590311 9461 80.91.229.3 (23 Oct 2015 08:51:51 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 23 Oct 2015 08:51:51 +0000 (UTC)
Cc: Rich Felker <dalias@libc.org>,
	Denys Vlasenko <vda.linux@googlemail.com>
To: musl@lists.openwall.com
Original-X-From: musl-return-8748-gllmg-musl=m.gmane.org@lists.openwall.com Fri Oct 23 10:51:45 2015
Return-path: <musl-return-8748-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-8748-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1ZpY4b-00005v-8e
	for gllmg-musl@m.gmane.org; Fri, 23 Oct 2015 10:51:41 +0200
Original-Received: (qmail 15566 invoked by uid 550); 23 Oct 2015 08:51:33 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 15542 invoked from network); 23 Oct 2015 08:51:33 -0000
Mail-Followup-To: musl@lists.openwall.com, Rich Felker <dalias@libc.org>,
	Denys Vlasenko <vda.linux@googlemail.com>
Content-Disposition: inline
In-Reply-To: <1445582865-4141-1-git-send-email-vda.linux@googlemail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Xref: news.gmane.org gmane.linux.lib.musl.general:8735
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/8735>

* Denys Vlasenko <vda.linux@googlemail.com> [2015-10-23 08:47:45 +0200]:
> +Note that overriding variables on make command line (IOW, running
> +make CFLAGS="...") is not tested to work properly, and may result
> +in a severely suboptimal build. Place your overrides into environment:
> +
> +  export CFLAGS="..."; make
> +
> +or
> +
> +  CFLAGS="..." make
> +

i think that does not work, env vars affect make vars if

 VAR ?=
 VAR +=

or no VAR assignment is used in the makefile.

musl happens to use CFLAGS= in config.mak

>  EOF
>  exit 0
>  }
> -- 
> 1.8.1.4