mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Having hard time adding to CFLAGS
Date: Sat, 24 Oct 2015 15:37:53 -0400	[thread overview]
Message-ID: <20151024193753.GS8645@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAK1hOcO7jznCbRHmJDtb_wV4Fni6Fx1QRvte2D1vy_3SuT01Zw@mail.gmail.com>

On Fri, Oct 23, 2015 at 08:47:18AM +0200, Denys Vlasenko wrote:
> On Fri, Oct 23, 2015 at 7:16 AM, Rich Felker <dalias@libc.org> wrote:
> >> Currently, it is confusing. See for yourself:
> >>
> >>
> >> Usage: $0 [OPTION]... [VAR=VALUE]... [TARGET]
> >>
> >> To assign environment variables (e.g., CC, CFLAGS...), specify them as
> >> VAR=VALUE.  See below for descriptions of some of the useful variables.
> >> ....
> >> ("ok, I got it. CFLAGS should go to configure's command line!")
> >> ....
> >> Some influential environment variables:
> >>   CC                      C compiler command [detected]
> >>   CFLAGS                  C compiler flags [-Os -pipe ...]
> >>   CROSS_COMPILE           prefix for cross compiler and tools [none]
> >>   LIBCC                   compiler runtime library [detected]
> >>
> >> Use these variables to override the choices made by configure.
> >>
> >> ("What? You just said that CFLAGS should be on command line!
> >> Now you are saying it should be in the environment!
> >> What it is?")
> >
> > The behavior is the same as autoconf: they're accepted either as
> > environment variables or on the configure command line. Some users do:
> >
> >         CFLAGS=... ./configure ...
> >
> > and others do:
> >
> >         ./configure CFLAGS=... ...
> 
> I tested both and they indeed work identically.
> 
> > I can add some language to the help text to make it explicit that
> > either is accepted.
> 
> I'm sending you a patch with amended --help text.

I'd like to continue discussion of whether the current behavior is
actually desirable. It's quite possible that we should move the
configure-generated CFLAGS to a separate variable where they're not
clobbered by setting of CFLAGS by the user at make time.

Rich


      reply	other threads:[~2015-10-24 19:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 22:31 Denys Vlasenko
2015-10-22 23:04 ` Josiah Worcester
2015-10-23  0:13   ` Denys Vlasenko
2015-10-22 23:23 ` Szabolcs Nagy
2015-10-23  3:02   ` Rich Felker
2015-10-23  4:09     ` Rich Felker
2015-10-23  4:53       ` Denys Vlasenko
2015-10-23  5:16         ` Rich Felker
2015-10-23  6:47           ` Denys Vlasenko
2015-10-24 19:37             ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151024193753.GS8645@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).