From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8800 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [PATCH] prevent allocs than PTRDIFF_MAX via mremap Date: Sat, 31 Oct 2015 16:30:39 -0400 Message-ID: <20151031203039.GJ8645@brightrain.aerifal.cx> References: <1446282885-5290-1-git-send-email-danielmicay@gmail.com> <563487CA.5080706@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446323458 10395 80.91.229.3 (31 Oct 2015 20:30:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2015 20:30:58 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8813-gllmg-musl=m.gmane.org@lists.openwall.com Sat Oct 31 21:30:58 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Zscnh-0007dw-C4 for gllmg-musl@m.gmane.org; Sat, 31 Oct 2015 21:30:57 +0100 Original-Received: (qmail 13390 invoked by uid 550); 31 Oct 2015 20:30:53 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 13355 invoked from network); 31 Oct 2015 20:30:52 -0000 Content-Disposition: inline In-Reply-To: <563487CA.5080706@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:8800 Archived-At: On Sat, Oct 31, 2015 at 05:20:10AM -0400, Daniel Micay wrote: > It seems like a call to __vm_wait() might also be needed here when > MREMAP_FIXED is passed as a flag. I don't know anything about robust > futexes though, so someone else will need to figure that out. Thanks. I'll review both issues and see if there's anything else wrong in this file. I think there's at least one other conceptual problem: use of va_arg when the flags that do indicate that a variadic argument was passed. Rich