From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8817 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] don't define SHARED macro in the source Date: Sat, 7 Nov 2015 14:24:04 +0100 Message-ID: <20151107132404.GD8500@port70.net> References: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446902660 10716 80.91.229.3 (7 Nov 2015 13:24:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Nov 2015 13:24:20 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8830-gllmg-musl=m.gmane.org@lists.openwall.com Sat Nov 07 14:24:18 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Zv3Td-0005b5-Ms for gllmg-musl@m.gmane.org; Sat, 07 Nov 2015 14:24:17 +0100 Original-Received: (qmail 20167 invoked by uid 550); 7 Nov 2015 13:24:16 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 20149 invoked from network); 7 Nov 2015 13:24:15 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Xref: news.gmane.org gmane.linux.lib.musl.general:8817 Archived-At: * Petr Hosek [2015-11-06 23:46:40 +0000]: > When building musl with pnacl-clang compiler I found a bug: crt/rcrt1.c > defines the SHARED macro which enables the conditional block in > src/ldso/dlstart.c, this breaks for us because pnacl-clang doesn't support > shared libraries nor inline assembly. If my understanding is correct, the > SHARED macro should be (and already is) defined only in CFLAGS_ALL_SHARED. > The attached patch fixes that. but rcrt1.o is not built with CFLAGS_ALL_SHARED and SHARED is needed rcrt1.o should be only used for static pie > From 7b1348fa1a8dd2d02a9087639c6b02ce9585aef2 Mon Sep 17 00:00:00 2001 > From: Petr Hosek > Date: Thu, 5 Nov 2015 21:55:20 -0800 > Subject: [PATCH] don't define SHARED macro in the source > > the SHARED macro should only be defined in CFLAGS_ALL_SHARED when > building musl as shared library. > --- > crt/rcrt1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/crt/rcrt1.c b/crt/rcrt1.c > index 9be117f..0ba78f8 100644 > --- a/crt/rcrt1.c > +++ b/crt/rcrt1.c > @@ -1,4 +1,3 @@ > -#define SHARED > #define START "_start" > #define _dlstart_c _start_c > #include "../src/ldso/dlstart.c" > -- > 2.6.0.rc2.230.g3dd15c0 >