From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Support for out-of-tree build
Date: Tue, 17 Nov 2015 19:19:55 -0500 [thread overview]
Message-ID: <20151118001955.GI3818@brightrain.aerifal.cx> (raw)
In-Reply-To: <CABBv4Tb0jjq5uER-s=bKKN2cw=2--1iKWTkJd0q14jhnkAqLAw@mail.gmail.com>
On Tue, Nov 17, 2015 at 11:54:23PM +0000, Petr Hosek wrote:
> This'll work if we remove the .sub files as discussed, with .sub files it
> becomes more complicated.
Are you sure? I think the only complicated part for the *.sub files is
the automatic dependency generation to make sure the .o files get
rebuild when the potentially-pointed-to .s files change. Otherwise
they are just like .s files in how they're handled except that you use
`cat $<` in place of $<.
BTW could you refrain from top posting on the list? Even if you just
have a short reply that's in regards to the whole quoted message
rather than specific points to address inline, things get awkward to
follow in a hurry (just like now) when somebody else replies to you
but also wants to keep the quoted content you were replying to as
context (like below).
> On Tue, Nov 17, 2015 at 3:43 PM Rich Felker <dalias@libc.org> wrote:
>
> > On Tue, Nov 17, 2015 at 06:27:11PM -0500, Rich Felker wrote:
> > > Assuming .o files in arch dirs are ok, does the following work
> > > (non-VPATH)?
> > >
> > > %.o: $(srcdir)/%.sub
> > > ...
> > > %.o: $(srcdir)/%.s
> > > ...
> > > %.o: $(srcdir)/%.c
> > > ...
> > >
> > > (with appropriate commands, of course). If so, I think I like it a
> > > lot, because it factors the rules for file *types* separately from the
> > > rules for which files to select (the "tricky" $(OBJS) setting). The
> > > only big concern is whether this "tricky" setting is too costly in
> > > runtime performance or complexity.
> >
> > Here's my idea for the 'tricky' setting of OBJS and it actually looks
> > very simple and efficient:
> >
> > ARCH_OBJS = $(wildcard ...)
> > BASE_OBJS = $(wildcard ...)
> > OBJS = $(ARCH_OBJS) $(filter-out $(ARCH_OBJS:/$(ARCH)/=/),$(BASE_OBJS))
Discussion on irc, along with some basic testing, showed that this
does not work. The obvious solution with $(subst ...) also does not
work because it's plausible that $(srcdir) also contains the substring
/$(ARCH)/, in which case it would get messed up. However I did find a
form that seems to work reliably and that's not hideous:
$(patsubst %,$(srcdir)/%,$(subst /$(ARCH)/,/,$(patsubst $(srcdir)/%,%,$(ARCH_OBJS))))
That yields the list of object files to filter out, which can then be
passed into $(filter-out ...).
Rich
next prev parent reply other threads:[~2015-11-18 0:19 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 23:40 Petr Hosek
2015-11-07 13:05 ` Szabolcs Nagy
2015-11-08 0:43 ` Rich Felker
2015-11-08 2:16 ` Szabolcs Nagy
2015-11-08 2:29 ` Rich Felker
2015-11-11 22:02 ` Petr Hosek
2015-11-11 23:08 ` Rich Felker
2015-11-12 0:01 ` Rich Felker
2015-11-12 0:28 ` Petr Hosek
2015-11-12 14:50 ` Szabolcs Nagy
2015-11-12 20:17 ` Petr Hosek
2015-11-12 20:30 ` Rich Felker
2015-11-12 21:10 ` Szabolcs Nagy
2015-11-12 21:52 ` Rich Felker
2015-11-12 22:35 ` Petr Hosek
2015-11-12 23:41 ` Rich Felker
2015-11-17 2:45 ` Petr Hosek
2015-11-17 6:05 ` Petr Hosek
2015-11-17 19:51 ` Szabolcs Nagy
2015-11-17 21:00 ` Rich Felker
2015-11-17 21:37 ` Petr Hosek
2015-11-17 22:01 ` Rich Felker
2015-11-17 22:15 ` Petr Hosek
2015-11-17 22:58 ` Rich Felker
2015-11-17 23:06 ` Szabolcs Nagy
2015-11-17 23:27 ` Rich Felker
2015-11-17 23:43 ` Rich Felker
2015-11-17 23:54 ` Petr Hosek
2015-11-18 0:19 ` Szabolcs Nagy
2015-11-18 0:19 ` Rich Felker [this message]
2015-11-18 20:19 ` Petr Hosek
2015-11-18 21:44 ` Rich Felker
2015-11-19 0:22 ` Petr Hosek
2015-11-20 4:09 ` Rich Felker
2015-11-20 5:02 ` Rich Felker
2015-11-20 10:51 ` Szabolcs Nagy
2015-11-30 1:25 ` Petr Hosek
2015-11-20 22:20 ` Rich Felker
2015-11-30 1:29 ` Petr Hosek
2015-11-30 1:35 ` Rich Felker
2015-11-30 2:49 ` Petr Hosek
2015-11-30 21:14 ` Rich Felker
2015-11-30 22:14 ` Rich Felker
2015-12-01 2:14 ` Petr Hosek
2015-12-09 0:39 ` Rich Felker
2015-12-10 1:39 ` Petr Hosek
2015-12-10 12:47 ` Szabolcs Nagy
2016-01-17 22:32 ` Rich Felker
2016-01-17 23:41 ` Szabolcs Nagy
2016-01-20 3:49 ` Rich Felker
2015-11-21 1:05 ` Szabolcs Nagy
2015-11-21 1:16 ` Szabolcs Nagy
2015-11-22 14:56 ` Szabolcs Nagy
2015-11-30 1:30 ` Petr Hosek
2015-11-30 12:01 ` Szabolcs Nagy
2015-11-30 22:22 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118001955.GI3818@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).