From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCHv2] properly handle point-to-point interfaces in getifaddrs()
Date: Mon, 30 Nov 2015 15:01:47 -0500 [thread overview]
Message-ID: <20151130200147.GU3818@brightrain.aerifal.cx> (raw)
In-Reply-To: <1447965790-8151-1-git-send-email-jow@openwrt.org>
On Thu, Nov 19, 2015 at 09:43:10PM +0100, Jo-Philipp Wich wrote:
> With point-to-point interfaces, the IFA_ADDRESS netlink attribute contains
> the peer address while an extra attribute IFA_LOCAL carries the actual local
> interface address.
>
> Both the glibc and uclibc implementations of getifaddrs() handle this case
> by moving the ifa_addr contents to the broadcast/remote address union and
> overwriting ifa_addr upon receipt of an IFA_LOCAL attribute.
>
> This patch adds the same special treatment logic of IFA_LOCAL to musl's
> implementation of getifaddrs() in order to align its behaviour with that
> of uclibc and musl.
^^^^ glibc
Committed, fixing this and line folding in the commit message;
otherwise, unchanged. Thanks!
Rich
prev parent reply other threads:[~2015-11-30 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 10:33 Fix handling of peer-to-peer " Jo-Philipp Wich
2015-11-17 10:33 ` [PATCH] properly handle point-to-point " Jo-Philipp Wich
2015-11-19 20:43 ` [PATCHv2] " Jo-Philipp Wich
2015-11-21 9:14 ` Timo Teras
2015-11-21 19:20 ` Rich Felker
2015-11-23 9:12 ` Timo Teras
2015-11-23 17:01 ` Rich Felker
2015-11-30 20:01 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130200147.GU3818@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).