From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9040 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] netinet/tcp: Add TCPOPT, TCPOLEN constants Date: Sat, 2 Jan 2016 23:24:54 -0500 Message-ID: <20160103042454.GS238@brightrain.aerifal.cx> References: <42734146-83D1-41CA-9389-5D14284BD2A2@shiz.me> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1451795129 21928 80.91.229.3 (3 Jan 2016 04:25:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jan 2016 04:25:29 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9053-gllmg-musl=m.gmane.org@lists.openwall.com Sun Jan 03 05:25:11 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aFaEB-0007Gv-8k for gllmg-musl@m.gmane.org; Sun, 03 Jan 2016 05:25:11 +0100 Original-Received: (qmail 14323 invoked by uid 550); 3 Jan 2016 04:25:08 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 14302 invoked from network); 3 Jan 2016 04:25:07 -0000 Content-Disposition: inline In-Reply-To: <42734146-83D1-41CA-9389-5D14284BD2A2@shiz.me> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:9040 Archived-At: On Sat, Jan 02, 2016 at 08:15:16PM +0100, Shiz wrote: > > > On 02 Jan 2016, at 03:18, Kylie McClain wrote: > > > > I've attached it since I don't trust gmail to not mess up patch > > formatting. > > This seems off: > > >+#ifdef defined(_BSD_SOURCE) > > I think you either want #ifdef _BSD_SOURCE or #if defined(_BSD_SOURCE) here. Yes. Also, due to the way things currently work, I think it's necessary to test defined(_BSD_SOURCE) || defined(_GNU_SOURCE). I don't like that and want to fix it at the features.h level, but this is an overhaul fix that should be made all at once rather than with incremental inconsistency, so for now it's best to just test both here, I think. Also, it seems there's already a section later in the file that's conditional on BSD||GNU, so unless there's a good conceptual reason not to I'd probably rather add the new constants there. Does this sound okay? Rich