From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix if_nametoindex return value when socket open fails
Date: Fri, 15 Jan 2016 13:57:18 -0500 [thread overview]
Message-ID: <20160115185718.GF238@brightrain.aerifal.cx> (raw)
In-Reply-To: <5698be60.uat8s3q4Wfvl5TQE%rmy@frippery.org>
On Fri, Jan 15, 2016 at 09:39:44AM +0000, Ron Yorston wrote:
> The return value of if_nametoindex is unsigned; it should return 0
> on error.
> ---
> src/network/if_nametoindex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/network/if_nametoindex.c b/src/network/if_nametoindex.c
> index cb6ec05..331413c 100644
> --- a/src/network/if_nametoindex.c
> +++ b/src/network/if_nametoindex.c
> @@ -10,7 +10,7 @@ unsigned if_nametoindex(const char *name)
> struct ifreq ifr;
> int fd, r;
>
> - if ((fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0)) < 0) return -1;
> + if ((fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0)) < 0) return 0;
> strncpy(ifr.ifr_name, name, sizeof ifr.ifr_name);
> r = ioctl(fd, SIOCGIFINDEX, &ifr);
> __syscall(SYS_close, fd);
> --
> 2.5.0
Looks good. Actually it's unclear from the spec what should happen,
since "No errors are defined":
http://pubs.opengroup.org/onlinepubs/9699919799/functions/if_nametoindex.html
But 0 is specified as the return value for names which do not exist.
It seems unfortunate that applications can't distinguish between
errors and "no such name", but I don't think we can fix this on our
end. Someone should file a bug in POSIX and the resolution should
probably be that if_nametoindex leaves errno unchanged and returns 0
when the name does not exist, and sets errno and returns 0 when an
internal error occurs.
Rich
next prev parent reply other threads:[~2016-01-15 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:39 Ron Yorston
2016-01-15 18:57 ` Rich Felker [this message]
2016-01-17 22:34 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115185718.GF238@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).