mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix wrapper auto detection in configure
Date: Fri, 22 Jan 2016 18:47:45 -0500	[thread overview]
Message-ID: <20160122234745.GX238@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160122215603.GG9621@port70.net>

On Fri, Jan 22, 2016 at 10:56:03PM +0100, Szabolcs Nagy wrote:
> the libc header based test is wrong if there are no such headers on the
> system only a free standing cc, which should be enough for a musl build.

I'm trying to understand the usage case you're concerned about. Is it
failing to build the wrapper for a glibc-targeted toolchain that
doesn't actually have glibc installed? Is there a reason you woul want
the wrapper in this case?

> check for *-musl* in the target triplet instead.

I don't think we depend on the target tuple at all now except as a way
of identifying the arch. It's only available with gcc, not other
compilers that lack -dumpmachine. I was actually thinking about this
issue a couple days ago and wonder if we should instead check for
predefined macros defined in the psABI for each arch to determine the
arch. This would also work on non-gcc compilers so you don't have to
manually pass the target arch (or tuple) to configure for them.

Anyway if I can understand what real problem you're trying to solve
maybe I can come up with a better approach that doesn't expend
dependency on having a named target tuple.

Rich


  reply	other threads:[~2016-01-22 23:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 21:56 Szabolcs Nagy
2016-01-22 23:47 ` Rich Felker [this message]
2016-01-23  0:32   ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160122234745.GX238@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).