From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9176 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix wrapper auto detection in configure Date: Fri, 22 Jan 2016 18:47:45 -0500 Message-ID: <20160122234745.GX238@brightrain.aerifal.cx> References: <20160122215603.GG9621@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1453506483 8675 80.91.229.3 (22 Jan 2016 23:48:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jan 2016 23:48:03 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9189-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jan 23 00:48:02 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aMlQv-0004PI-Fp for gllmg-musl@m.gmane.org; Sat, 23 Jan 2016 00:48:01 +0100 Original-Received: (qmail 26084 invoked by uid 550); 22 Jan 2016 23:47:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 26066 invoked from network); 22 Jan 2016 23:47:58 -0000 Content-Disposition: inline In-Reply-To: <20160122215603.GG9621@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:9176 Archived-At: On Fri, Jan 22, 2016 at 10:56:03PM +0100, Szabolcs Nagy wrote: > the libc header based test is wrong if there are no such headers on the > system only a free standing cc, which should be enough for a musl build. I'm trying to understand the usage case you're concerned about. Is it failing to build the wrapper for a glibc-targeted toolchain that doesn't actually have glibc installed? Is there a reason you woul want the wrapper in this case? > check for *-musl* in the target triplet instead. I don't think we depend on the target tuple at all now except as a way of identifying the arch. It's only available with gcc, not other compilers that lack -dumpmachine. I was actually thinking about this issue a couple days ago and wonder if we should instead check for predefined macros defined in the psABI for each arch to determine the arch. This would also work on non-gcc compilers so you don't have to manually pass the target arch (or tuple) to configure for them. Anyway if I can understand what real problem you're trying to solve maybe I can come up with a better approach that doesn't expend dependency on having a named target tuple. Rich