mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix unresolved symbol issues on ARMv7 due to raise/divmod dependency
Date: Tue, 23 Feb 2016 15:45:48 -0500	[thread overview]
Message-ID: <20160223204548.GQ9349@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160223204337.GB29662@port70.net>

On Tue, Feb 23, 2016 at 09:43:37PM +0100, Szabolcs Nagy wrote:
> * Dima Krasner <dima@dimakrasner.com> [2016-02-23 22:21:20 +0200]:
> > Similar to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=31798
> > 
> > Signed-off-by: Dima Krasner <dima@dimakrasner.com>
> > ---
> >  tools/ld.musl-clang.in | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/ld.musl-clang.in b/tools/ld.musl-clang.in
> > index 93763d6..bb6cbaf 100644
> > --- a/tools/ld.musl-clang.in
> > +++ b/tools/ld.musl-clang.in
> > @@ -48,4 +48,5 @@ for x ; do
> >      esac
> >  done
> >  
> > -exec $($cc -print-prog-name=ld) -nostdlib "$@" -lc -dynamic-linker "$ldso"
> > +lgcc=$($cc -print-file-name=libgcc.a)
> > +exec $($cc -print-prog-name=ld) -nostdlib "$@" --as-needed $lgcc --no-as-needed -lc --as-needed $lgcc --no-as-needed -dynamic-linker "$ldso"
> 
> this workaround should be only done if clang uses libgcc
> (and not compiler_rt)

The --as-needed stuff is also not needed; it's a nop for static
libraries, which -lgcc always is. But I'm unclear why this patch is
needed to begin with, and why -lc was there already. The compiler
should be passing in the right -l options.

Rich


  reply	other threads:[~2016-02-23 20:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 20:21 Dima Krasner
2016-02-23 20:43 ` Szabolcs Nagy
2016-02-23 20:45   ` Rich Felker [this message]
2016-02-23 21:06     ` Shiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223204548.GQ9349@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).