From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9411 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] add sched_getcpu Date: Mon, 29 Feb 2016 15:05:00 -0500 Message-ID: <20160229200500.GC9349@brightrain.aerifal.cx> References: <1456765028-23958-1-git-send-email-nathan@nathan7.eu> <1456765216-24883-1-git-send-email-nathan@nathan7.eu> <20160229183816.GB9349@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1456776316 31286 80.91.229.3 (29 Feb 2016 20:05:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Feb 2016 20:05:16 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9424-gllmg-musl=m.gmane.org@lists.openwall.com Mon Feb 29 21:05:15 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aaU4B-0008QU-A8 for gllmg-musl@m.gmane.org; Mon, 29 Feb 2016 21:05:15 +0100 Original-Received: (qmail 23710 invoked by uid 550); 29 Feb 2016 20:05:13 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23687 invoked from network); 29 Feb 2016 20:05:13 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:9411 Archived-At: On Mon, Feb 29, 2016 at 10:59:10PM +0300, Alexander Monakov wrote: > On Mon, 29 Feb 2016, Rich Felker wrote: > > > (this include could also be dropped; I think it's a matter of policy whether > > > such includes are desirable or not, so please wait for comment from Rich) > > > > Policy is to always include the header with the public declaration > > (and any feature test macros necessary to get it) so that the compiler > > checks the implementation against the public declaration. > > This policy certain makes sense; I pointed that out because I've seen it > violated; at least the following files violate it by defining something > without including anything: Thanks for tracking these down. See below: > arch/arm/src/__aeabi_atexit.c This ia an ABI function but has no public declaration and is not callable as API. > src/internal/procfdname.c This is an internal function. > src/misc/gethostid.c Should be fixed to include unistd.h. > src/prng/__seed48.c > src/signal/restore.c Internal. > src/signal/sigrtmin.c ABI but the symbol is exposed via a public macro in signal.h so I think we should include the header. > src/stdlib/abs.c > src/stdlib/labs.c > src/stdlib/llabs.c Definitely should include header. > src/time/__month_to_secs.c > src/time/__year_to_secs.c Internal. Rich