From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: iproute2 & other software
Date: Wed, 2 Mar 2016 18:18:08 -0500 [thread overview]
Message-ID: <20160302231808.GO9349@brightrain.aerifal.cx> (raw)
In-Reply-To: <9E4ED0C3-B227-43C9-864E-11C66CCECA8C@gmail.com>
On Wed, Mar 02, 2016 at 12:44:51PM -0800, Khem Raj wrote:
>
> > On Mar 2, 2016, at 12:39 PM, Loganaden Velvindron <loganaden@gmail.com> wrote:
> >
> >
> >
> > On Wed, Mar 2, 2016 at 8:37 PM, Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> wrote:
> >
> > > On Mar 2, 2016, at 11:19 AM, Loganaden Velvindron <loganaden@gmail.com <mailto:loganaden@gmail.com>> wrote:
> > >
> > > Hi All,
> > >
> > > Stephen (iproute2) sent me a mail telling me that he rejected my patch to iproute2 for musl support:
> > >
> > > 1st reply:
> > > "
> > > I was waiting for others who had more to say on this.
> > > Ok with providing small fixes, but can't really guarantee iproute to
> > > work with other libraries.
> > > "
> > >
> > > & 2nd is :
> > > "
> > > Sorry, I have to reject this.
> > > All include files in include/linux come from headers automatically generated from upstream
> > > Linux source. This is the only way to ensure long term ABI/API consistency
> > > with kernel.
> > >
> > > Either fix musl or submit patches to upstream kernel and get them merged.
> > > “
> >
> > Where is your patch.
> >
> >
> > Rejected patch here:
> >
> > https://patchwork.ozlabs.org/patch/586121/ <https://patchwork.ozlabs.org/patch/586121/>
> >
>
> The change needs a bit more description of the problem its trying to fix.
> Concern is if it will still work with glibc or uclibc on linux
> one way you could keep functionality same for existing libcs
> is to ifdef these files with #ifdef __GLIBC__
Indeed, I don't think the patch makes sense as submitted. MAXPATHLEN
is a deprecated, nonstandard form of PATH_MAX and should not be used
at all; adding #include <sys/param.h>, a messy legacy header with a
hodgepodge of junk in it, is making the codebase worse rather than
better.
Removing #include <linux/in.h> and #include <linux/in6.h> is probably
correct, but you should check and explain that all the types used from
these headers are already defined by standard headers (netinet/in.h?)
and that including the redundant Linux headers at best creates a risk
of conflict and if nothing else is useless.
Rich
next prev parent reply other threads:[~2016-03-02 23:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 19:19 Loganaden Velvindron
2016-03-02 20:37 ` Khem Raj
2016-03-02 20:39 ` Loganaden Velvindron
2016-03-02 20:44 ` Khem Raj
2016-03-02 23:18 ` Rich Felker [this message]
2016-03-02 20:49 ` Szabolcs Nagy
2016-03-02 23:30 ` Rich Felker
2016-03-03 10:10 ` Szabolcs Nagy
2016-03-03 16:00 ` Rich Felker
2016-03-03 16:12 Kylie McClain
2016-03-03 17:01 ` Szabolcs Nagy
2016-03-03 19:05 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302231808.GO9349@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).