From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9443 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: iproute2 & other software Date: Wed, 2 Mar 2016 18:18:08 -0500 Message-ID: <20160302231808.GO9349@brightrain.aerifal.cx> References: <0DED8CA5-AABF-471F-AF89-26BFCB3F7B40@gmail.com> <9E4ED0C3-B227-43C9-864E-11C66CCECA8C@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1456960706 27482 80.91.229.3 (2 Mar 2016 23:18:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Mar 2016 23:18:26 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9456-gllmg-musl=m.gmane.org@lists.openwall.com Thu Mar 03 00:18:25 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1abG2C-0007PE-8i for gllmg-musl@m.gmane.org; Thu, 03 Mar 2016 00:18:24 +0100 Original-Received: (qmail 23933 invoked by uid 550); 2 Mar 2016 23:18:21 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23908 invoked from network); 2 Mar 2016 23:18:20 -0000 Content-Disposition: inline In-Reply-To: <9E4ED0C3-B227-43C9-864E-11C66CCECA8C@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:9443 Archived-At: On Wed, Mar 02, 2016 at 12:44:51PM -0800, Khem Raj wrote: > > > On Mar 2, 2016, at 12:39 PM, Loganaden Velvindron wrote: > > > > > > > > On Wed, Mar 2, 2016 at 8:37 PM, Khem Raj > wrote: > > > > > On Mar 2, 2016, at 11:19 AM, Loganaden Velvindron > wrote: > > > > > > Hi All, > > > > > > Stephen (iproute2) sent me a mail telling me that he rejected my patch to iproute2 for musl support: > > > > > > 1st reply: > > > " > > > I was waiting for others who had more to say on this. > > > Ok with providing small fixes, but can't really guarantee iproute to > > > work with other libraries. > > > " > > > > > > & 2nd is : > > > " > > > Sorry, I have to reject this. > > > All include files in include/linux come from headers automatically generated from upstream > > > Linux source. This is the only way to ensure long term ABI/API consistency > > > with kernel. > > > > > > Either fix musl or submit patches to upstream kernel and get them merged. > > > “ > > > > Where is your patch. > > > > > > Rejected patch here: > > > > https://patchwork.ozlabs.org/patch/586121/ > > > > The change needs a bit more description of the problem its trying to fix. > Concern is if it will still work with glibc or uclibc on linux > one way you could keep functionality same for existing libcs > is to ifdef these files with #ifdef __GLIBC__ Indeed, I don't think the patch makes sense as submitted. MAXPATHLEN is a deprecated, nonstandard form of PATH_MAX and should not be used at all; adding #include , a messy legacy header with a hodgepodge of junk in it, is making the codebase worse rather than better. Removing #include and #include is probably correct, but you should check and explain that all the types used from these headers are already defined by standard headers (netinet/in.h?) and that including the redundant Linux headers at best creates a risk of conflict and if nothing else is useless. Rich