From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 0/2] add sched_getcpu, take n+1
Date: Wed, 2 Mar 2016 22:01:39 -0500 [thread overview]
Message-ID: <20160303030139.GU9349@brightrain.aerifal.cx> (raw)
In-Reply-To: <1456935987-24047-1-git-send-email-nathan@nathan7.eu>
On Wed, Mar 02, 2016 at 05:26:25PM +0100, Nathan Zadoks wrote:
> > Wrong macro in the #ifdef.
> Whoops, thanks, fixed!
>
> > Not a big deal, but usually in musl we use 0 rather than the NULL
> > macro.
> Learnt a new thing there - fixed!
>
> > Actually I wondered if the function actually needs to take the useless
> > extra 2 arguments, but I think for the sake of correctness it's best
> > to do it this way -- the callee in the vdso has 3 args, so it should
> > be called with the correct type.
> The second argument actually needs to be null: it's an out pointer for
> an identifier for the NUMA node. sched_getcpu doesn't have a spot for
> returning it, so we pass a null pointer there, which ignores it.
> The *third* argument is a pointer to a now-unused cache structure,
> and could probably be omitted safely. It's required to be non-NULL on kernels
> older than 2.6.23, but we'd just end up corrupting random memory there
> instead of getting an EFAULT. Not worth saving a register zeroing instruction.
Agreed.
> > One other thing I thought might be nice is initially committing the
> > trivial syscall-only version that adds the public prototype, then
> > doing vdso support as a separate commit, but if that's a pain to do
> > don't worry about it.
> No problem! Some git trickery later, I've got this sorted.
Great. Applying now. Thanks!
Rich
next prev parent reply other threads:[~2016-03-03 3:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 16:49 [PATCH] add sched_getcpu Nathan Zadoks
2016-02-29 16:57 ` Nathan Zadoks
2016-02-29 16:57 ` Nathan Zadoks
2016-02-29 17:00 ` Nathan Zadoks
2016-02-29 17:23 ` Alexander Monakov
2016-02-29 17:33 ` Alexander Monakov
2016-03-01 13:45 ` [PATCH] add sched_getcpu, with vDSO support Nathan Zadoks
2016-03-01 15:56 ` Nathan Zadoks
2016-03-02 5:55 ` Rich Felker
2016-03-02 16:26 ` [PATCH 0/2] add sched_getcpu, take n+1 Nathan Zadoks
2016-03-02 16:26 ` [PATCH 1/2] add sched_getcpu Nathan Zadoks
2016-03-02 16:26 ` [PATCH 2/2] add sched_getcpu vDSO support Nathan Zadoks
2016-03-03 3:01 ` Rich Felker [this message]
2016-02-29 17:49 ` [PATCH] add sched_getcpu nathan
2016-02-29 17:52 ` nathan
2016-02-29 20:17 ` Alexander Monakov
2016-02-29 20:49 ` Nathan Zadoks
2016-02-29 18:38 ` Rich Felker
2016-02-29 19:59 ` Alexander Monakov
2016-02-29 20:05 ` Rich Felker
2016-02-29 20:10 ` Alexander Monakov
2016-02-29 20:17 ` Rich Felker
2016-02-29 21:09 ` Tomasz Sterna
2016-02-29 21:21 ` Nathan Zadoks
2016-02-29 21:30 ` Rich Felker
2016-03-01 20:35 ` Tomasz Sterna
2016-03-01 22:34 ` Rich Felker
2016-03-02 20:46 ` Tomasz Sterna
2016-03-02 21:19 ` Szabolcs Nagy
2016-03-02 23:26 ` Rich Felker
2016-03-04 22:21 ` Tomasz Sterna
2016-03-04 23:33 ` Rich Felker
2016-03-05 11:40 ` Tomasz Sterna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303030139.GU9349@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).