From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9524 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Define LONG_DOUBLE_IS_* internal macros. Date: Tue, 8 Mar 2016 00:05:27 -0500 Message-ID: <20160308050527.GA9349@brightrain.aerifal.cx> References: <1457404695-17281-1-git-send-email-masanori.ogino@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1457413545 12610 80.91.229.3 (8 Mar 2016 05:05:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 05:05:45 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9537-gllmg-musl=m.gmane.org@lists.openwall.com Tue Mar 08 06:05:45 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ad9q4-0003bl-7c for gllmg-musl@m.gmane.org; Tue, 08 Mar 2016 06:05:44 +0100 Original-Received: (qmail 12179 invoked by uid 550); 8 Mar 2016 05:05:41 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 12157 invoked from network); 8 Mar 2016 05:05:40 -0000 Content-Disposition: inline In-Reply-To: <1457404695-17281-1-git-send-email-masanori.ogino@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:9524 Archived-At: On Tue, Mar 08, 2016 at 11:38:15AM +0900, OGINO Masanori wrote: > These macros indicate which format is used for long double with the > toolchain. > > Although the meaning of "LDBL_DIG_MANT == 64 && LDBL_MAX_EXP == 16384" > is very clear to floating-point arithmetic guys, it is nice to have > descriptive names to such conditions. I understand where you're coming from but I think this is opposite to the style preferences in musl, which are to avoid dependence on internal things and directly use portable conditions based on public interfaces where possible. The existing tests are all completely valid even outside musl, without depending on any musl-internal stuff. If the intent is not clear, perhaps some simple comments would suffice? Rich