From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rich Felker <dalias@libc.org>, Andy Lutomirski <luto@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
"musl@lists.openwall.com" <musl@lists.openwall.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: Re: [RFC PATCH] x86/vdso/32: Add AT_SYSINFO cancellation helpers
Date: Sat, 12 Mar 2016 18:00:40 +0100 [thread overview]
Message-ID: <20160312170040.GA1108@gmail.com> (raw)
In-Reply-To: <CA+55aFxvMM3j1aWjN-kr5Hn8CUC_RSNw5hc+X8zFXMaMv+mGww@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> [...]
>
> Because if that's the case, I wonder if what you really want is not "sticky
> signals" as much as "synchronous signals" - ie the ability to say that a signal
> shouldn't ever interrupt in random places, but only at well-defined points
> (where a system call would be one such point - are there others?)
Yes, I had similar 'deferred signal delivery' thoughts after having written up the
sticky signals approach, I just couldn't map all details of the semantics: see the
'internal libc functions' problem below.
If we can do this approach then there's another advantage as well: this way the C
library does not even have to poll for cancellation at syscall boundaries: i.e.
the regular system call fast path gets faster by 2-3 instructions as well.
> So then you could make "pthread_setcanceltype()" just set that flag for the
> cancellation signal, and just know that the signal itself will always be
> deferred to such a synchronous point (ie system call entry).
>
> We already have the ability to catch things at system call entry (ptrace needs
> it, for example), so we could possibly make our signal delivery have a mode
> where a signal does *not* cause user space execution to be interrupted by a
> signal handler, but instead just sets a bit in the thread info state that then
> causes the next system call to take the signal.
Yes, so this would need a bit of work, to handle the problem mentioned by Rich
Felker: "internal" libc APIs (such as name server lookups) may consist of a series
of complex system calls - some of which might be blocking. It should still be
possible to execute such 'internal' system calls undisturbed, even if a 'deferred'
signal is sent.
One workable solution I think would be to prepare the internal functions for
eventual interruption by the cancellation signal. They have to be restartable
anyway, because the application can send other signals. As long as the
interruption is only transient it should be fine.
And note that this approach would also be pretty fast on the libc side: none of
the 'fast' cancellation APIs would have to do anything complex like per call
signal blocking/unblocking or other complex signal operations. They would just
activate a straightforward new SA_ flag and rely on its semantics.
Thanks,
Ingo
next prev parent reply other threads:[~2016-03-12 17:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 1:24 Andy Lutomirski
2016-03-09 8:56 ` Ingo Molnar
2016-03-09 11:34 ` Szabolcs Nagy
2016-03-09 11:40 ` Szabolcs Nagy
2016-03-09 19:47 ` [musl] " Linus Torvalds
2016-03-09 20:57 ` Andy Lutomirski
2016-03-09 21:26 ` Linus Torvalds
2016-03-10 10:57 ` Ingo Molnar
2016-03-10 3:34 ` [musl] " Rich Felker
2016-03-10 11:16 ` Ingo Molnar
2016-03-10 16:41 ` Rich Felker
2016-03-10 18:03 ` Ingo Molnar
2016-03-10 23:28 ` [musl] " Rich Felker
2016-03-11 0:18 ` Szabolcs Nagy
2016-03-11 0:48 ` [musl] " Rich Felker
2016-03-11 1:14 ` Andy Lutomirski
2016-03-11 1:39 ` Szabolcs Nagy
2016-03-11 1:49 ` Szabolcs Nagy
2016-03-11 1:55 ` [musl] " Rich Felker
2016-03-11 9:33 ` Ingo Molnar
2016-03-11 11:39 ` Szabolcs Nagy
2016-03-11 19:27 ` Linus Torvalds
2016-03-11 19:30 ` [musl] " Andy Lutomirski
2016-03-11 19:39 ` Linus Torvalds
2016-03-11 19:44 ` Linus Torvalds
2016-03-12 17:05 ` Ingo Molnar
2016-03-12 18:10 ` [musl] " Rich Felker
2016-03-12 17:00 ` Ingo Molnar [this message]
2016-03-12 18:05 ` Rich Felker
2016-03-12 18:48 ` Ingo Molnar
2016-03-12 19:08 ` [musl] " Rich Felker
2016-03-12 17:08 ` Ingo Molnar
2016-03-09 17:58 ` Andy Lutomirski
2016-03-09 21:19 ` Andy Lutomirski
2016-03-12 18:13 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160312170040.GA1108@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=musl@lists.openwall.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).