From: Solar Designer <solar@openwall.com>
To: musl@lists.openwall.com
Cc: Timo Teras <timo.teras@iki.fi>
Subject: Re: [PATCH] crypt_blowfish: allow short salt strings
Date: Sun, 27 Mar 2016 18:22:16 +0300 [thread overview]
Message-ID: <20160327152216.GA31328@openwall.com> (raw)
In-Reply-To: <20160327025404.GA29124@openwall.com>
On Sun, Mar 27, 2016 at 05:54:04AM +0300, Solar Designer wrote:
> I found that PHP's hack was introduced in commit:
>
> commit 03315d9625dc87515f1dfbf1cc7d53c4451b5ec9
> Author: Pierre Joye <pajoye@php.net>
> Date: Mon Jul 18 21:26:29 2011 +0000
>
> - update blowfish to 1.2 (Solar Designer)
>
> $ git show 03315d9625dc87515f1dfbf1cc7d53c4451b5ec9 | fgrep -i hack
> + if (tmp == '$') break; /* PHP hack */ \
> + while (dptr < end) /* PHP hack */
Correction: this commit merely documented the hack with those comments,
but the hack itself was in there before.
I just brought the issue up on the PHP internals list:
http://news.php.net/php.internals/91969
A sub-issue is that the padding appears to vary between PHP versions or
builds: some pad with zero bits, and some (5.4.x only?) with '$' signs.
Alexander
next prev parent reply other threads:[~2016-03-27 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 12:12 Timo Teräs
2016-03-27 2:11 ` Solar Designer
2016-03-27 2:54 ` Solar Designer
2016-03-27 15:22 ` Solar Designer [this message]
2016-03-27 3:30 ` Solar Designer
2016-03-27 13:26 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160327152216.GA31328@openwall.com \
--to=solar@openwall.com \
--cc=musl@lists.openwall.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).