From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] add powerpc64 port
Date: Mon, 28 Mar 2016 05:27:10 +0200 [thread overview]
Message-ID: <20160328032709.GH9862@port70.net> (raw)
In-Reply-To: <20160328021856.GG21636@brightrain.aerifal.cx>
* Rich Felker <dalias@libc.org> [2016-03-27 22:18:56 -0400]:
> On Sun, Mar 27, 2016 at 07:32:20PM -0500, Bobby Bingham wrote:
> > On Sun, Mar 27, 2016 at 07:37:09PM -0400, Rich Felker wrote:
> > > On Sun, Mar 27, 2016 at 04:20:19PM -0500, Bobby Bingham wrote:
> > > > +#define SA_NOCLDSTOP 1U
> > > > +#define SA_NOCLDWAIT 2U
> > > > +#define SA_SIGINFO 4U
> > > > +#define SA_ONSTACK 0x08000000U
> > > > +#define SA_RESTART 0x10000000U
> > > > +#define SA_NODEFER 0x40000000U
> > > > +#define SA_RESETHAND 0x80000000U
i guess at least this one has to be unsigned
and then others should follow
i think there are other cases where a 1U<<31 flag
forces all others to be unsigned otherwise there
are possible signed int overflow issues
(even though the linux uapi may use signed int)
e.g.
EPOLL* in sys/epoll.h
MS_NOUSER in sys/mount.h ?
> > > > +#define SA_RESTORER 0x04000000U
> > >
> > > Is there a reason for making these unsigned? It's different from other
> > > archs at least, I think.
> >
> > It's the same as the ppc32 port.
>
> OK. Maybe it should be changed but that's a separate issue.
>
next prev parent reply other threads:[~2016-03-28 3:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 21:20 [RFC] " Bobby Bingham
2016-03-27 21:20 ` [PATCH 1/2] add 64bit atomics on top of 64bit ll/sc primitives Bobby Bingham
2016-03-27 22:27 ` Rich Felker
2016-03-27 21:20 ` [PATCH 2/2] add powerpc64 port Bobby Bingham
2016-03-27 23:37 ` Rich Felker
2016-03-28 0:32 ` Bobby Bingham
2016-03-28 2:18 ` Rich Felker
2016-03-28 3:27 ` Szabolcs Nagy [this message]
2016-04-02 17:02 ` Bobby Bingham
2016-04-03 2:09 ` Rich Felker
2016-04-03 17:10 ` Bobby Bingham
2016-04-03 17:26 ` Rich Felker
2016-04-03 17:50 ` Bobby Bingham
2016-04-04 4:03 ` Bobby Bingham
2016-04-04 10:41 ` Szabolcs Nagy
2016-03-28 22:00 ` Patrick Oppenlander
2016-03-28 22:10 ` Rich Felker
2016-03-28 23:04 ` Patrick Oppenlander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328032709.GH9862@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).