From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9756 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] add powerpc64 port Date: Mon, 28 Mar 2016 05:27:10 +0200 Message-ID: <20160328032709.GH9862@port70.net> References: <1459113619-24090-1-git-send-email-koorogi@koorogi.info> <1459113619-24090-3-git-send-email-koorogi@koorogi.info> <20160327233709.GE21636@brightrain.aerifal.cx> <20160328003220.GA24176@dora.lan> <20160328021856.GG21636@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1459135647 13255 80.91.229.3 (28 Mar 2016 03:27:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Mar 2016 03:27:27 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9769-gllmg-musl=m.gmane.org@lists.openwall.com Mon Mar 28 05:27:26 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1akNpt-0007C0-Q6 for gllmg-musl@m.gmane.org; Mon, 28 Mar 2016 05:27:25 +0200 Original-Received: (qmail 12066 invoked by uid 550); 28 Mar 2016 03:27:22 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 12047 invoked from network); 28 Mar 2016 03:27:21 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20160328021856.GG21636@brightrain.aerifal.cx> User-Agent: Mutt/1.5.24 (2015-08-30) Xref: news.gmane.org gmane.linux.lib.musl.general:9756 Archived-At: * Rich Felker [2016-03-27 22:18:56 -0400]: > On Sun, Mar 27, 2016 at 07:32:20PM -0500, Bobby Bingham wrote: > > On Sun, Mar 27, 2016 at 07:37:09PM -0400, Rich Felker wrote: > > > On Sun, Mar 27, 2016 at 04:20:19PM -0500, Bobby Bingham wrote: > > > > +#define SA_NOCLDSTOP 1U > > > > +#define SA_NOCLDWAIT 2U > > > > +#define SA_SIGINFO 4U > > > > +#define SA_ONSTACK 0x08000000U > > > > +#define SA_RESTART 0x10000000U > > > > +#define SA_NODEFER 0x40000000U > > > > +#define SA_RESETHAND 0x80000000U i guess at least this one has to be unsigned and then others should follow i think there are other cases where a 1U<<31 flag forces all others to be unsigned otherwise there are possible signed int overflow issues (even though the linux uapi may use signed int) e.g. EPOLL* in sys/epoll.h MS_NOUSER in sys/mount.h ? > > > > +#define SA_RESTORER 0x04000000U > > > > > > Is there a reason for making these unsigned? It's different from other > > > archs at least, I think. > > > > It's the same as the ppc32 port. > > OK. Maybe it should be changed but that's a separate issue. >