From: Bobby Bingham <koorogi@koorogi.info>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] add powerpc64 port
Date: Sun, 3 Apr 2016 23:03:54 -0500 [thread overview]
Message-ID: <20160404040353.GA12493@dora.lan> (raw)
In-Reply-To: <20160328021856.GG21636@brightrain.aerifal.cx>
On Sun, Mar 27, 2016 at 10:18:56PM -0400, Rich Felker wrote:
> > > > diff --git a/arch/powerpc64/reloc.h b/arch/powerpc64/reloc.h
> > > > new file mode 100644
> > > > index 0000000..8e60b31
> > > > --- /dev/null
> > > > +++ b/arch/powerpc64/reloc.h
> > > > @@ -0,0 +1,32 @@
> > > > +#include <endian.h>
> > > > +
> > > > +#if __BYTE_ORDER == __LITTLE_ENDIAN
> > > > +#define ENDIAN_SUFFIX "le"
> > > > +#else
> > > > +#define ENDIAN_SUFFIX ""
> > > > +#endif
> > > > +
> > > > +#define LDSO_ARCH "powerpc64" ENDIAN_SUFFIX
> > >
> > > Is it intentional that the "default" subarch variant be suffixed with
> > > "le" and a non-default/unused one be the bare "powerpc64"? I don't
> > > object to that but it's contrary to usual conventions that the bare
> > > arch be the canonical ABI, and it might be contrary to what GCC is
> > > doing now (haven't checked) for the dynamic linker name.
> >
> > I'll double check, but I skimmed the gcc code here, and it looked like
> > it uses an "le" suffix. Admittedly, I didn't read it closely enough to
> > be absolutely sure yet.
>
> OK, sounds good. Also note that CRTJMP here needs fixing.
I checked again, and gcc does indeed use the "le" suffix.
gcc/config/rs6000/linux64.h has:
#define MUSL_DYNAMIC_LINKER64 \
"/lib/ld-musl-powerpc64" MUSL_DYNAMIC_LINKER_E "%{msoft-float:-sf}.so.1"
The two places that define MUSL_DYNAMIC_LINKER_E define it like so:
gcc/config/rs6000/sysv4.h:
#define MUSL_DYNAMIC_LINKER_E ENDIAN_SELECT("", "le", "")
gcc/config/rs6000/sysv4le.h:
#define MUSL_DYNAMIC_LINKER_E ENDIAN_SELECT("", "le", "le")
--
Bobby
next prev parent reply other threads:[~2016-04-04 4:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 21:20 [RFC] " Bobby Bingham
2016-03-27 21:20 ` [PATCH 1/2] add 64bit atomics on top of 64bit ll/sc primitives Bobby Bingham
2016-03-27 22:27 ` Rich Felker
2016-03-27 21:20 ` [PATCH 2/2] add powerpc64 port Bobby Bingham
2016-03-27 23:37 ` Rich Felker
2016-03-28 0:32 ` Bobby Bingham
2016-03-28 2:18 ` Rich Felker
2016-03-28 3:27 ` Szabolcs Nagy
2016-04-02 17:02 ` Bobby Bingham
2016-04-03 2:09 ` Rich Felker
2016-04-03 17:10 ` Bobby Bingham
2016-04-03 17:26 ` Rich Felker
2016-04-03 17:50 ` Bobby Bingham
2016-04-04 4:03 ` Bobby Bingham [this message]
2016-04-04 10:41 ` Szabolcs Nagy
2016-03-28 22:00 ` Patrick Oppenlander
2016-03-28 22:10 ` Rich Felker
2016-03-28 23:04 ` Patrick Oppenlander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404040353.GA12493@dora.lan \
--to=koorogi@koorogi.info \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).