From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9906 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v2] add powerpc64 port Date: Thu, 14 Apr 2016 15:42:13 +0200 Message-ID: <20160414134213.GG22574@port70.net> References: <1459747571-9123-1-git-send-email-koorogi@koorogi.info> <20160413230506.GE22574@port70.net> <20160414080138.GA23694@dora.lan> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1460641350 28602 80.91.229.3 (14 Apr 2016 13:42:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Apr 2016 13:42:30 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9919-gllmg-musl=m.gmane.org@lists.openwall.com Thu Apr 14 15:42:29 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aqhXQ-0003le-UH for gllmg-musl@m.gmane.org; Thu, 14 Apr 2016 15:42:29 +0200 Original-Received: (qmail 11728 invoked by uid 550); 14 Apr 2016 13:42:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 11702 invoked from network); 14 Apr 2016 13:42:25 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20160414080138.GA23694@dora.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Xref: news.gmane.org gmane.linux.lib.musl.general:9906 Archived-At: * Bobby Bingham [2016-04-14 03:01:38 -0500]: > On Thu, Apr 14, 2016 at 01:05:07AM +0200, Szabolcs Nagy wrote: > > * Bobby Bingham [2016-04-04 00:26:11 -0500]: > > > +++ b/arch/powerpc64/bits/setjmp.h > > > @@ -0,0 +1 @@ > > > +typedef unsigned long long __jmp_buf[66]; > > > > hm glibc seems to use long[64] with 16byte alignment, > > is the size diff because of alignment? > > Yes. Though apparently the glibc setjmp asm has code to detect a > misaligned jmp_buf, but its handling of that case ends up overflowing > the jmp_buf. > > I can make some changes to get our jmp_buf down to 65, but the only ways > to get it down to 64 are either with 16 byte alignment, or to have setjmp > spill vector registers to the stack first so it can copy them from there > to the jmp_buf through a gpr. > > How important is it to match glibc here? > i think we don't care about abi compat (but it might be interesting to check how much abi difference there is between glibc and musl, i can do this if i can build a musl+glibc toolchain) i just wanted to make sure we understand the cause of the difference.