mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH] res_msend: Remove unnecessary line
@ 2016-04-17 14:53 Petr Vaněk
  2016-04-18  5:29 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Vaněk @ 2016-04-17 14:53 UTC (permalink / raw)
  To: musl

The variable nss is set to zero in following line, therefore this line
is not needed.
---
 src/network/res_msend.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/network/res_msend.c b/src/network/res_msend.c
index a47d18d..de7f615 100644
--- a/src/network/res_msend.c
+++ b/src/network/res_msend.c
@@ -52,7 +52,6 @@ int __res_msend_rc(int nqueries, const unsigned char *const *queries,
 	timeout = 1000*conf->timeout;
 	attempts = conf->attempts;
 
-	nns = conf->nns;
 	for (nns=0; nns<conf->nns; nns++) {
 		const struct address *iplit = &conf->ns[nns];
 		if (iplit->family == AF_INET) {
-- 
2.7.3



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] res_msend: Remove unnecessary line
  2016-04-17 14:53 [PATCH] res_msend: Remove unnecessary line Petr Vaněk
@ 2016-04-18  5:29 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-04-18  5:29 UTC (permalink / raw)
  To: musl

On Sun, Apr 17, 2016 at 02:53:08PM +0000, Petr Vaněk wrote:
> The variable nss is set to zero in following line, therefore this line
> is not needed.

Indeed, this looks like cruft left over from when I was writing that
code. Thanks, applied.

Rich

> ---
>  src/network/res_msend.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/network/res_msend.c b/src/network/res_msend.c
> index a47d18d..de7f615 100644
> --- a/src/network/res_msend.c
> +++ b/src/network/res_msend.c
> @@ -52,7 +52,6 @@ int __res_msend_rc(int nqueries, const unsigned char *const *queries,
>  	timeout = 1000*conf->timeout;
>  	attempts = conf->attempts;
>  
> -	nns = conf->nns;
>  	for (nns=0; nns<conf->nns; nns++) {
>  		const struct address *iplit = &conf->ns[nns];
>  		if (iplit->family == AF_INET) {
> -- 
> 2.7.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-18  5:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-17 14:53 [PATCH] res_msend: Remove unnecessary line Petr Vaněk
2016-04-18  5:29 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).