From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 04/12] update elf.h with new aarch64 relocs
Date: Wed, 20 Apr 2016 13:18:41 -0400 [thread overview]
Message-ID: <20160420171841.GV21636@brightrain.aerifal.cx> (raw)
In-Reply-To: <76673580c2b9f4be2b5b21c5ad7ccd7a99ee165f.1460669067.git.nsz@port70.net>
On Wed, Apr 20, 2016 at 01:15:37PM +0200, Szabolcs Nagy wrote:
> add ilp32 related relocs and fix the names of a few macros following
> https://sourceware.org/ml/libc-alpha/2014-11/msg00455.html
> ---
> include/elf.h | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/include/elf.h b/include/elf.h
> index 1bfe016..0dcc1f2 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -2105,8 +2105,17 @@ typedef Elf32_Addr Elf32_Conflict;
> #define SHT_ARM_PREEMPTMAP (SHT_LOPROC + 2)
> #define SHT_ARM_ATTRIBUTES (SHT_LOPROC + 3)
>
> -
> #define R_AARCH64_NONE 0
> +#define R_AARCH64_P32_ABS32 1
> +#define R_AARCH64_P32_COPY 180
> +#define R_AARCH64_P32_GLOB_DAT 181
> +#define R_AARCH64_P32_JUMP_SLOT 182
> +#define R_AARCH64_P32_RELATIVE 183
> +#define R_AARCH64_P32_TLS_DTPMOD 184
> +#define R_AARCH64_P32_TLS_DTPREL 185
> +#define R_AARCH64_P32_TLS_TPREL 186
> +#define R_AARCH64_P32_TLSDESC 187
> +#define R_AARCH64_P32_IRELATIVE 188
> #define R_AARCH64_ABS64 257
> #define R_AARCH64_ABS32 258
> #define R_AARCH64_ABS16 259
> @@ -2224,9 +2233,9 @@ typedef Elf32_Addr Elf32_Conflict;
> #define R_AARCH64_GLOB_DAT 1025
> #define R_AARCH64_JUMP_SLOT 1026
> #define R_AARCH64_RELATIVE 1027
> -#define R_AARCH64_TLS_DTPMOD64 1028
> -#define R_AARCH64_TLS_DTPREL64 1029
> -#define R_AARCH64_TLS_TPREL64 1030
> +#define R_AARCH64_TLS_DTPMOD 1028
> +#define R_AARCH64_TLS_DTPREL 1029
> +#define R_AARCH64_TLS_TPREL 1030
> #define R_AARCH64_TLSDESC 1031
Did you test this? From what I can see, it breaks the build, though I
don't have a cross compiler handy to actually check. See
arch/aarch64/reloc.h. If there's a possibility any other software is
using the old names we should probably add rather than change (like
the OR1K/OPENRISC issue).
Rich
next prev parent reply other threads:[~2016-04-20 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 11:13 [PATCH 00/12] update elf.h to follow glibc changes Szabolcs Nagy
2016-04-20 11:14 ` [PATCH 01/12] add EM_OPENRISC again to elf.h Szabolcs Nagy
2016-04-20 11:14 ` [PATCH 02/12] add new powerpc64 relocations " Szabolcs Nagy
2016-04-20 11:15 ` [PATCH 03/12] update elf.h with powerpc64 elfv2 abi related macros Szabolcs Nagy
2016-04-20 11:15 ` [PATCH 04/12] update elf.h with new aarch64 relocs Szabolcs Nagy
2016-04-20 17:18 ` Rich Felker [this message]
2016-07-03 20:13 ` Szabolcs Nagy
2016-04-20 11:17 ` [PATCH 05/12] update elf.h with mips abi flags support Szabolcs Nagy
2016-04-20 11:17 ` [PATCH 06/12] add nios2 definitions to elf.h Szabolcs Nagy
2016-04-20 11:17 ` [PATCH 07/12] add powerpc tls optimization related " Szabolcs Nagy
2016-04-20 11:19 ` [PATCH 08/12] add SHF_COMPRESSED section flag " Szabolcs Nagy
2016-04-20 11:19 ` [PATCH 09/12] add DT_MIPS_RLD_MAP_REL " Szabolcs Nagy
2016-04-20 11:19 ` [PATCH 10/12] add missing x86 relocs " Szabolcs Nagy
2016-04-20 11:20 ` [PATCH 11/12] add NT_ARM_SYSTEM_CALL " Szabolcs Nagy
2016-04-20 11:20 ` [PATCH 12/12] add EF_SH_ sh specific macros " Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420171841.GV21636@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).