From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10008 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: musl-cross-make / litecross improvements Date: Fri, 6 May 2016 01:14:29 -0400 Message-ID: <20160506051428.GY21636@brightrain.aerifal.cx> References: <20160503044835.GA5517@brightrain.aerifal.cx> <20160503113942.GS22574@port70.net> <20160503180230.GL21636@brightrain.aerifal.cx> <20160503201622.GT22574@port70.net> <20160503215705.GU22574@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1462511689 14660 80.91.229.3 (6 May 2016 05:14:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 May 2016 05:14:49 +0000 (UTC) Cc: j-core@j-core.org To: musl@lists.openwall.com Original-X-From: musl-return-10021-gllmg-musl=m.gmane.org@lists.openwall.com Fri May 06 07:14:46 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ayY6A-0000Ma-Dk for gllmg-musl@m.gmane.org; Fri, 06 May 2016 07:14:46 +0200 Original-Received: (qmail 28036 invoked by uid 550); 6 May 2016 05:14:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 28008 invoked from network); 6 May 2016 05:14:42 -0000 Content-Disposition: inline In-Reply-To: <20160503215705.GU22574@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10008 Archived-At: On Tue, May 03, 2016 at 11:57:05PM +0200, Szabolcs Nagy wrote: > * Szabolcs Nagy [2016-05-03 22:16:22 +0200]: > > * Rich Felker [2016-05-03 14:02:30 -0400]: > > > On Tue, May 03, 2016 at 01:39:43PM +0200, Szabolcs Nagy wrote: > > > > i think the usr/ and lib64/ symlinks are useful > > > > (so it can be used as rootfs without fiddling > > > > with etc/ld-musl*.path). > > > > > > Yes. Is there a good way to override that in gcc or should we just > > > make the symlinks? > > > > > > > output/lib64 can be eliminated by > > COMMON_CONFIG += --libdir=/lib > > > > output/x86_64-linux-musl/lib64 install path is trickier: > > it is controlled by the $toolexeclibdir make variable. > > which is set according to $CC -print-multi-os-directory > > which is controlled by multilib and multilib_defaults from > > $CC -dumpspecs which comes from multilib.h generated by > > genmultilib based on parameters from config/i386/t-linux64 > > > > it was not clear if the t-linux64 thing could be overridden, but > > GCC_CONFIG += --with-multilib-list= > > fixes it (the lib dir is lib/ then). I've looked into this more, and while I think your approach works in practice, I'm a bit concerned that --with-multilib-list= is processed per-target and in theory the blank list might break something. I tried x86_64, sh, and aarch64, but several other archs remain, I think. The root cause of this bug seems to be a broken conditional in gcc/Makefile.in; for the s-mlib rule, the condition for building multilib layout is: if test @enable_multilib@ = yes \ || test -n "$(MULTILIB_OSDIRNAMES)"; then \ I believe the || should have been &&. In any case, forcing MULTILIB_OSDIRNAMES= on the make command line seems like a viable solution. I'm testing it now and I'll probably commit as long as it works. Rich