From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10032 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Deduplicating __NR_* and SYS_* syscall defines Date: Fri, 13 May 2016 12:02:19 -0400 Message-ID: <20160513160219.GM21636@brightrain.aerifal.cx> References: <20160510002637.GA21262@dora.lan> <20160511215311.GI21636@brightrain.aerifal.cx> <20160512002230.GA23989@dora.lan> <20160512005712.GK21636@brightrain.aerifal.cx> <20160513101548.GE22574@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1463155367 15131 80.91.229.3 (13 May 2016 16:02:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 May 2016 16:02:47 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10045-gllmg-musl=m.gmane.org@lists.openwall.com Fri May 13 18:02:47 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1b1FY2-0004Eo-C2 for gllmg-musl@m.gmane.org; Fri, 13 May 2016 18:02:42 +0200 Original-Received: (qmail 32439 invoked by uid 550); 13 May 2016 16:02:33 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32418 invoked from network); 13 May 2016 16:02:32 -0000 Content-Disposition: inline In-Reply-To: <20160513101548.GE22574@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10032 Archived-At: On Fri, May 13, 2016 at 12:15:48PM +0200, Szabolcs Nagy wrote: > * Rich Felker [2016-05-11 20:57:12 -0400]: > > On Wed, May 11, 2016 at 07:22:30PM -0500, Bobby Bingham wrote: > > > On Wed, May 11, 2016 at 05:53:12PM -0400, Rich Felker wrote: > > > > On Mon, May 09, 2016 at 07:26:37PM -0500, Bobby Bingham wrote: > > > > > During the powerpc64 review, Rich mentioned wanting to replace the > > > > > arch/*/bits/syscall.h files with .in files that would be preprocessed with > > > > > something like: > > > > > > > > > > sed -e p -e s/__NR_/SYS_/ < $< > $@ > > > > > > > > > > This would eliminate a lot of intra-file duplication here. > > i don't know how much is it worth to keep the syntax consistent > with kernel headers, i'd just clean these up with special syntax > like TYPEDEF in alltypes e.g. > > SYS write 1 This does save some space (maybe 25-30% size reduction?) but I think it also comes at the sense of some flexibility and readability. For example if there are ever archs where the definitions need to depend on some compile-time macros (e.g. if we had an arch where it makes sense to put a couple ABI variants with different syscalls together as subarchs rather than independent archs) there becomes a question of how to format those conditions and whether their directives would be misinterpreted. Having #define on every line so that the file as-is is valid preprocessor input avoids any such issues. Of course these things are also a reason to possibly prefer the form with SYS_ and __NR_ interleaved (my original sed command). With them separate like the current proposed patch, anything inside a conditional block or dependent on interleaved redefinition of other macros would break. > with consistent whitespace, removed comments etc. Agree on consistent whitespace (and we should do that regardless of the rest of this proposal), but note that it can't necessarily be just 3 space-delimited tokens. Some archs have arithmetic expressions for the integer field, and requiring that not to contain whitespace would be rather arbitrary and confusing, so the last field would probably need to be the whole remainder of the line. Rich