mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: a64l(): return value should be sign extended
Date: Mon, 23 May 2016 18:30:30 -0400	[thread overview]
Message-ID: <20160523223030.GH21636@brightrain.aerifal.cx> (raw)
In-Reply-To: <CABh_MKkNiTPC+mevnyLa1vNH2LnpyCOOT-=Ko+ZBUYTR06zZSg@mail.gmail.com>

On Mon, May 23, 2016 at 08:01:24PM +0200, Ed Schouten wrote:
> Hi there,
> 
> While reading some of musl's sources, I think I might have found a
> tiny bug, though I haven't tested the code myself.
> 
> The 'x' variable in the a64l() function has type uint32_t, meaning
> that the function computes a value between [0,2^32). According to
> POSIX, the return value of this function should be sign extended --
> not zero extended -- in case long is larger than 32 bits. This means
> that the return statement in this function should either cast x to an
> int32_t, or the declaration of x should be changed to an int32_t.

Thanks. There are actually several more bugs here. I'm fixing them all
together; see the commit message for details:

https://git.musl-libc.org/cgit/musl/commit/?id=77baaa47e107f176fb2dc150dd6a9ad87f6cbe24

Rich


      reply	other threads:[~2016-05-23 22:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 18:01 Ed Schouten
2016-05-23 22:30 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523223030.GH21636@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).