From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: sockaddr_storage and GCC 6.1
Date: Tue, 24 May 2016 18:36:02 -0400 [thread overview]
Message-ID: <20160524223602.GL21636@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160524220735.GA19259@wilbur.25thandClement.com>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
On Tue, May 24, 2016 at 03:07:35PM -0700, William Ahern wrote:
> GCC 6.1 more aggressively decomposes aggregate assignments into a series of
> scalar member assignments. This has uncovered an issue with glibc's layout
> of struct sockaddr_storage, which has a padding hole from offsets 2 to 8,
> precisely where .sin_port and .sin_addr are in struct sockaddr_in.
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71120
>
> musl shares this same issue. Specifically, the __ss_align member with an
> 8-byte alignment on LP64 archs. You can track the glibc resolution at
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=20111
>
> Or not track it. Reasonable folks can disagree regarding many aspects of
> this issue, but I thought it worthwhile to bring to people's attention.
I maintain that it's a bug (violation of effective type rules) for a
program to attempt to copy sockaddr types using sockaddr_storage, but
this is a nasty application bug to track down (usually silent
breakage) that's worth avoiding since it's easy. Does the attached
patch work?
I don't think we should even consider the sorts of may_alias hacks
glibc/gcc folks are discussing, though. There's already a gcc option
for compiling broken code like that; it's called -fno-strict-aliasing.
Rich
[-- Attachment #2: sockaddr_storage.diff --]
[-- Type: text/plain, Size: 356 bytes --]
diff --git a/include/sys/socket.h b/include/sys/socket.h
index 6788375..d2bd5df 100644
--- a/include/sys/socket.h
+++ b/include/sys/socket.h
@@ -286,7 +286,7 @@ struct sockaddr
struct sockaddr_storage
{
- sa_family_t ss_family;
+ sa_family_t ss_family, __ss_family_pad;
unsigned long __ss_align;
char __ss_padding[128-2*sizeof(unsigned long)];
};
next prev parent reply other threads:[~2016-05-24 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 22:07 William Ahern
2016-05-24 22:36 ` Rich Felker [this message]
2016-05-24 22:55 ` Rich Felker
2016-05-24 23:21 ` Rich Felker
2016-05-26 20:21 William Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524223602.GL21636@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).