From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10088 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [PATCH v2] Add stdc-predef.h. Date: Fri, 3 Jun 2016 15:04:53 -0400 Message-ID: <20160603190453.GP10893@brightrain.aerifal.cx> References: <1459823023-5951-1-git-send-email-masanori.ogino@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1464980711 22993 80.91.229.3 (3 Jun 2016 19:05:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Jun 2016 19:05:11 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10101-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 03 21:05:11 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1b8uP7-0001NT-Ks for gllmg-musl@m.gmane.org; Fri, 03 Jun 2016 21:05:09 +0200 Original-Received: (qmail 7345 invoked by uid 550); 3 Jun 2016 19:05:07 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7324 invoked from network); 3 Jun 2016 19:05:07 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10088 Archived-At: On Wed, Jun 01, 2016 at 08:21:17AM +0000, Masanori Ogino wrote: > 2016年4月5日(火) 11:23 Masanori Ogino : > > > Note that GCC does not support the "Annex G" complex arithmetic even > > though __GCC_IEC_559_COMPLEX is defined. Thus, we leave > > __STDC_IEC_559_COMPLEX__ undefined for now. > > > > Reference: http://www.openwall.com/lists/musl/2016/03/31/2 > > > > Signed-off-by: Masanori Ogino > > --- > > include/stdc-predef.h | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > create mode 100644 include/stdc-predef.h > > > > diff --git a/include/stdc-predef.h b/include/stdc-predef.h > > new file mode 100644 > > index 0000000..baa8a54 > > --- /dev/null > > +++ b/include/stdc-predef.h > > @@ -0,0 +1,11 @@ > > +#ifndef _STDC_PREDEF_H > > +#define _STDC_PREDEF_H > > + > > +/* ISO/IEC 10646:2012, equivalent to Unicode 6.1 */ > > +#define __STDC_ISO_10646__ 201206L > > + > > +#if __GCC_IEC_559 > 0 > > +#define __STDC_IEC_559__ 1 > > +#endif > > + > > +#endif > > -- > > 2.7.3 > > > > > ping? I've actually had my own version of this pending for a long time now, so let's discuss it. My version was: #ifndef _STDC_PREDEF_H #define _STDC_PREDEF_H #define __STDC_ISO_10646__ 201103L #define __STDC_UTF_16__ 1 #define __STDC_UTF_32__ 1 #define __STDC_IEC_559__ 1 #define __STDC_NO_ATOMICS__ 1 #endif Obviously my Unicode date is older -- I haven't checked which is more correct, but after the next release we should update to latest Unicode anyway. Other than that, I also made explicit the UTF-16/32 macros that maybe should have been left to the compiler, and defined __STDC_NO_ATOMICS__ which is probably a bad idea since we might or might not support stdatomic.h depending on whether a compiler-provided or valid third-party version is available and working. The biggest question I think is what to do with __STDC_IEC_559__. My intent has always been to "support Annex F" and I think we do that for archs with hard float, but the lack of exceptions and rounding modes might be a conformance gap for soft-float archs. Your use of __GCC_IEC_559 gets around that, but fails to produce the desired value for (maybe hypothetical?) non-GCC compilers that don't define the gcc macro. It might be better to do something like: #if !defined(__GCC_IEC_559) || __GCC_IEC_559 > 0 #define __STDC_IEC_559__ 1 #endif What do you think? Anyone else have thoughts on the matter? Rich