From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10231 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Fix warnings when build with clang Date: Mon, 27 Jun 2016 13:21:59 -0400 Message-ID: <20160627172159.GH10893@brightrain.aerifal.cx> References: <20160625093707.GA19691@port70.net> <36ad2a0f7443ff7e95b7e927b49a2a87@codeaurora.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1467048135 16948 80.91.229.3 (27 Jun 2016 17:22:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2016 17:22:15 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10244-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 27 19:22:15 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bHaEh-0006wX-3I for gllmg-musl@m.gmane.org; Mon, 27 Jun 2016 19:22:15 +0200 Original-Received: (qmail 15949 invoked by uid 550); 27 Jun 2016 17:22:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 15929 invoked from network); 27 Jun 2016 17:22:12 -0000 Content-Disposition: inline In-Reply-To: <36ad2a0f7443ff7e95b7e927b49a2a87@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10231 Archived-At: On Mon, Jun 27, 2016 at 10:01:52AM -0700, weimingz@codeaurora.org wrote: > On 2016-06-25 02:37, Szabolcs Nagy wrote: > >* Zhao, Weiming [2016-06-24 17:18:23 -0700]: > >>Clang gives warnings about the missing parentheses for bitwise ops. > >> > >>It's not functional but just code readability. > >> > >>musl-m3/include/endian.h:32:25: warning: '&' within '|' > >>[-Wbitwise-op-parentheses] > >> return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24; > >> ~ ~~~~~~^~~~~~~ > > > >if clang warns about system headers that's a clang bug. > > The endian.h is a musl file. Right, which is why it's a system header. Rich