From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10245 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v2] refactor name_from_dns Date: Wed, 29 Jun 2016 12:04:50 -0400 Message-ID: <20160629160450.GL10893@brightrain.aerifal.cx> References: <20160527044057.GB10893@brightrain.aerifal.cx> <20160615182746.6728-1-ncopa@alpinelinux.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1467216311 15178 80.91.229.3 (29 Jun 2016 16:05:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Jun 2016 16:05:11 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10258-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 29 18:05:10 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bIHzA-0005NJ-JN for gllmg-musl@m.gmane.org; Wed, 29 Jun 2016 18:05:08 +0200 Original-Received: (qmail 1731 invoked by uid 550); 29 Jun 2016 16:05:05 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 1713 invoked from network); 29 Jun 2016 16:05:04 -0000 Content-Disposition: inline In-Reply-To: <20160615182746.6728-1-ncopa@alpinelinux.org> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10245 Archived-At: On Wed, Jun 15, 2016 at 08:27:46PM +0200, Natanael Copa wrote: > loop over an address family / resource record mapping to avoid > repetitive code. > --- > Changes since first version: > - use static const for the struct. As discussed in IRC gcc manages to > unroll it and the size of the name_from_dns (.text) is slightly smaller. Committed this and the first patch it depended on to fix the actual bug, with minor improvements to the commit message to address what code is being changed. Rich